Issue1338_Issue1417_Vertical height check and internal floor thicknesses in TwoPort #1435
Conversation
|
@jelgerjansen, can you please update the base branch to master to clean out the "files changed" tab? And if that doesn't work try switchting the base branch for a second and then back? (https://github.com/orgs/community/discussions/16351) |
jelgerjansen
changed the base branch from
issue1338_verifyVerticalHeights
to
master
jelgerjansen
changed the base branch from
master
to
issue1338_verifyVerticalHeights
|
@kldjonge I updated the branch open-ideas:issue1338_verifyVerticalHeights this morning to be up-to-date with the master branch, and changing the base to the master branch still leaves a lot of additional files in the "files changed" tab. |
Getting the derivatives of the spline only needs to be done once but was done each time the function was called.
Updated hFloor for PPD12 to account for floor heights. And set n50 parameter to use the inherited value.
… where necessary Updates to include the vertical height check including floor thicknesses. incInt where neccecarry in partial surface and internal wall, this is needed for when inc is set a custom value
This also tests the vertical height check asserts
included CO2 in the medium so I could check if the background CO2 of 400ppm actually entered the building. hFloor adapted in line with the vertical height check
|
@jelgerjansen, I managed to fix it! |
Added hVertical/2 to the error message so that the message also worked for errors when walls are vertical (e.g. split levels)
The n50_computed parameter is now always set to n50_int, removing the conditional logic since n50_int itself allready has the same conditional logic. This simplifies the parameter definition and should not lead to any changes in the reference results.
Updated the description string for the hRelSurfBot_a and hRelSurfBot_b parameters in PartialSurface and InternalWall to make them consistent.
jelgerjansen
left a comment
jelgerjansen
left a comment
There was a problem hiding this comment.
@kldjonge apart from the comments, don't forget to merge the latest master branch first to avoid conflicts (then I can also change the base branch to master)
@jelgerjansen, I merged the master (no conflicts). Can you maybe change the base branch allready or also merge the master in https://github.com/open-ideas/IDEAS/tree/issue1338_verifyVerticalHeights ? |
|
@jelgerjansen , potentially 55a535a, will shift the reference results for models with airflow. In IDEAS.Examples.TwinHouses.BuildingO5_Exp1_1Port, I allready checked the 'comparison' variables and that looks good. |
Both make sense. Both will probably change a bit again. |
Added a reference to GitHub issue open-ideas#1417 in the changelog for the InternalWall component to provide additional context for recent changes.
I suggest to add component-level output variables with consistent naming and positive values for the same flow direction, already much easier to interpret for the user although further improvements could be made later.
The function sin(pi) or pi(0) is approximate and did not lead to a clean dh=0 for ceilings or roof, which is a bit annoying.
Actually not nececarry to have two, simplifies without loss in accuracy
This reverts commit 5d2bb3a.
|
@kldjonge new reference results. 
|
The plot for 'Level.intFlo.crackOrOperableDoor.doo.dpAB' now only includes [1]
… update reference results
…this works" This reverts commit 3224ec4.
|
@jelgerjansen, thanks for the support and reviews on this big one! Appreciate it! |
3 participants
No description provided.