open-ideas · jelgerjansen · Aug 20, 2025 · Jul 10, 2025 · Jul 10, 2025 · Jul 10, 2025
diff --git a/IDEAS/Airflow/Multizone/CrackOrOperableDoor.mo b/IDEAS/Airflow/Multizone/CrackOrOperableDoor.mo
diff --git a/IDEAS/Airflow/Multizone/Validation/LargeHorizontalOpening.mo b/IDEAS/Airflow/Multizone/Validation/LargeHorizontalOpening.mo
@@ -7,7 +7,7 @@ model LargeHorizontalOpening
   Orifice Opening_Orifice(
     redeclare package Medium = Medium,
     useDefaultProperties=false,
-    dp_turbulent=Opening_CrackOrOperableDoor.dp_turbulent_ope,
+    dp_turbulent=Opening_CrackOrOperableDoor.dp_turbulent,
     A=2,
     CD=0.78) annotation (Placement(transformation(
         extent={{10,-10},{-10,10}},

diff --git a/IDEAS/Buildings/Components/Examples/CavityInternalCeiling.mo b/IDEAS/Buildings/Components/Examples/CavityInternalCeiling.mo
@@ -0,0 +1,47 @@
+within IDEAS.Buildings.Components.Examples;
+model CavityInternalCeiling
+  "Illustration of an internal ceiling with a cavity"
+  extends IDEAS.Buildings.Examples.ZoneExample(
+    sim(interZonalAirFlowType= IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts),internalWall(
+      redeclare parameter IDEAS.Buildings.Validation.Data.Constructions.LightWall constructionType,
+      incOpt=3,
+      hasCavity = true),
+    zone1(hFloor=zone.hFloor + zone.hZone + 0.195));
+
+  annotation (Icon(coordinateSystem(preserveAspectRatio=false)), Diagram(
+        coordinateSystem(preserveAspectRatio=false)),
+    experiment(
+      StopTime=108000,
+      Interval=720,
+      Tolerance=0.001,
+      __Dymola_Algorithm="Dassl"),
+    __Dymola_Commands(file="Resources/Scripts/Dymola/Buildings/Components/Examples/CavityInternalCeiling.mos"
+        "Simulate and plot"),
+    Documentation(info="<html>
+<p>
+This example contains an example use of an opening in an internal ceiling. 
+Note that it requires TwoPorts interzonal air flow (<code>interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts</code>).
+</p>
+</html>", revisions="<html>
+<ul>
+<li>
+August 13, 2025, by Klaas De Jonge:<br/>
+Updated construction type of Internal floor to <a href=modelica://IDEAS.Buildings.Validation.Data.Constructions.LightWall>
+IDEAS.Buildings.Validation.Data.Constructions.LightWall</a>
+</li>
+<li>
+February 05 2025, Klaas De Jonge<br>
+First implementation.
+</li>
+</ul>
+</html>"),
+    __Dymola_experimentSetupOutput,
+    __Dymola_experimentFlags(
+      Advanced(
+        EvaluateAlsoTop=false,
+        GenerateAnalyticJacobian=true,
+        OutputModelicaCode=false),
+      Evaluate=true,
+      OutputCPUtime=true,
+      OutputFlatModelica=false));
+end CavityInternalCeiling;
diff --git a/IDEAS/Buildings/Components/Examples/CavityInternalWall.mo b/IDEAS/Buildings/Components/Examples/CavityInternalWall.mo
@@ -1,12 +1,14 @@
 within IDEAS.Buildings.Components.Examples;
 model CavityInternalWall
   "Illustration of an internal wall with an operable cavity"
-  extends IDEAS.Buildings.Examples.ZoneExample(sim.interZonalAirFlowType = IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts, internalWall(hasCavity = true, use_y_doo = true));
+  extends IDEAS.Buildings.Examples.ZoneExample(sim(
+  interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts),
+  internalWall(hasCavity = true, use_y_doo = true));
   Modelica.Blocks.Sources.Sine sine(amplitude = 0.5, f = 1 / 7200, offset = 0.5)  annotation(
-    Placement(visible = true, transformation(origin = {-90, 10}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));equation
+    Placement(visible = true, transformation(origin = {-90, 10}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
+equation
   connect(internalWall.y_doo, sine.y) annotation(
-    Line(points = {{-16, 6}, {-16, 10}, {-78, 10}}, color = {0, 0, 127}));
-
+    Line(points={{-16.8,6.4},{-16.8,10},{-79,10}},  color = {0, 0, 127}));
   annotation (Icon(coordinateSystem(preserveAspectRatio=false)), Diagram(
         coordinateSystem(preserveAspectRatio=false)),
     experiment(

diff --git a/IDEAS/Buildings/Components/Examples/TwoStoreyBoxes.mo b/IDEAS/Buildings/Components/Examples/TwoStoreyBoxes.mo
@@ -5,7 +5,8 @@ model TwoStoreyBoxes "Model with two zones on different floors, one zone above t
   inner BoundaryConditions.SimInfoManager sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts,n50=1) annotation (Placement(transformation(extent={{-100,80},{-80,100}})));
 
   IDEAS.Buildings.Components.RectangularZoneTemplate Level(
-    hFloor=5,
+    Medium(extraPropertiesNames={"CO2"},C_nominal={1e-6}),
+    hFloor=5.25,
     T_start=291.15,
     bouTypA=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
     bouTypB=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
@@ -25,6 +26,7 @@ model TwoStoreyBoxes "Model with two zones on different floors, one zone above t
     annotation (Placement(transformation(extent={{-40,20},{-20,40}})));
 
   IDEAS.Buildings.Components.RectangularZoneTemplate Groundfloor(
+    Medium(extraPropertiesNames={"CO2"},C_nominal={1e-6}),
     T_start=291.15,
     bouTypA=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
     bouTypB=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
@@ -54,6 +56,9 @@ initial equation
   Groundfloor.gainCon.T=Tfix.port.T;
 
 equation
+  assert(Modelica.Math.isEqual(Groundfloor.ppm,sim.ppmCO2,eps=1),"CO2 should be at constant background level but isn't");
+  assert(Modelica.Math.isEqual(Level.ppm,sim.ppmCO2,eps=1),"CO2 should be at constant background level but isn't");
+
   connect(Groundfloor.proBusCei, Level.proBusFlo) annotation (Line(
       points={{-30.2,-24},{-30,-22},{-30,24}},
       color={255,204,51},
@@ -74,21 +79,22 @@ equation
         coordinateSystem(preserveAspectRatio=false)),
     experiment(
       StopTime=1209600,
-      Interval=3600.00288,
-      Tolerance=1e-12,
+      Interval=3600,
+      Tolerance=0.0001,
       __Dymola_fixedstepsize=15,
       __Dymola_Algorithm="Dassl"),
     Documentation(revisions="<html>
 <ul>
-<li>
-October 30, 2024, by Klaas De Jonge:<br/>
+<li>August 18, 2025, by Klaas De Jonge:<br>
+Added assert statements for CO2 background check,added C_nominal to medium declaration,changed tolerance in related .mos file,corrected Level.hFloor for <a href=\"https://github.com/open-ideas/IDEAS/issues/1338\">#1338</a></li>
+<li>October 30, 2024, by Klaas De Jonge:<br>
 First implementation
 </li>
 </ul>
 </html>", info="<html>
 <p>Model with two zones on different floors, one zone above the other, with a large opening between these zones and stack-effect airflow enabled.</p>
 </html>"),
     __Dymola_Commands(file=
-          "Resources/Scripts/Dymola/Buildings/Examples/TwoStoreyBoxes.mos"
+          "Resources/Scripts/Dymola/Buildings/Components/Examples/TwoStoreyBoxes.mos"
         "Simulate and Plot"));
 end TwoStoreyBoxes;
diff --git a/IDEAS/Buildings/Components/Examples/package.order b/IDEAS/Buildings/Components/Examples/package.order
@@ -1,6 +1,7 @@
 AirflowBoxModel
 BeamRadiationOnFloor
 BuildingShadeExample
+CavityInternalCeiling
 CavityInternalWall
 CavityWalls
 FacadeShadeExample

diff --git a/IDEAS/Buildings/Components/Interfaces/PartialSurface.mo b/IDEAS/Buildings/Components/Interfaces/PartialSurface.mo
@@ -43,17 +43,16 @@ partial model PartialSurface "Partial model for building envelope component"
   parameter Boolean use_custom_q50=false
     "check to disable the default q50 computation and to assign a custom q50 value"
     annotation (choices(checkBox=true),Dialog(tab="Airflow", group="Airtightness"), Evaluate=true);
-  parameter Real custom_q50(unit="m3/(h.m2)") = 2
+  parameter Real custom_q50(unit="m3/(h.m2)")=2
     "Surface air tightness"
     annotation (Dialog(enable=use_custom_q50,tab="Airflow", group="Airtightness"));
   final parameter Real q50_internal(unit="m3/(h.m2)",fixed=false)
     "Surface air tightness";
 
   final parameter Modelica.Units.SI.Length hzone_a( fixed=false);//connected with propsbus in inital equation
   final parameter Modelica.Units.SI.Length hAbs_floor_a( fixed=false);
-  parameter Modelica.Units.SI.Length hVertical=if IDEAS.Utilities.Math.Functions.isAngle(inc,IDEAS.Types.Tilt.Floor) or IDEAS.Utilities.Math.Functions.isAngle(inc,IDEAS.Types.Tilt.Ceiling) then 0 else hzone_a "Vertical surface height, height of the surface projected to the vertical, 0 for floors and ceilings" annotation(Evaluate=true);
-  parameter Modelica.Units.SI.Length hRelSurfBot_a= if IDEAS.Utilities.Math.Functions.isAngle(inc,IDEAS.Types.Tilt.Ceiling) then hzone_a else 0  "Height between the lowest point of the surface (bottom) and the floor level of the zone connected at propsBus_a"
-                                                                                                                                                                                                        annotation(Evaluate=true);
+  parameter Modelica.Units.SI.Length hVertical=if IDEAS.Utilities.Math.Functions.isAngle(incInt,IDEAS.Types.Tilt.Floor) or IDEAS.Utilities.Math.Functions.isAngle(incInt,IDEAS.Types.Tilt.Ceiling) then 0 else hzone_a "Vertical surface height, height of the surface projected to the vertical (e.g. 0 for floors and ceilings)" annotation(Evaluate=true,Dialog(group="Vertical position (important if interZonalAirFlowType is TwoPorts)"));
+  parameter Modelica.Units.SI.Length hRelSurfBot_a= if IDEAS.Utilities.Math.Functions.isAngle(incInt,IDEAS.Types.Tilt.Ceiling) then hzone_a else 0  "Height between the lowest point of the surface (bottom) and the floor level of the zone connected at propsBus_a (e.g. 0 for walls at floor level and floors.)" annotation(Evaluate=true,Dialog(group="Vertical position (important if interZonalAirFlowType is TwoPorts)"));
   final parameter Modelica.Units.SI.Length Habs_surf=hAbs_floor_a+hRelSurfBot_a+(hVertical/2)  "Absolute height of the middle of the surface, can be used to check the heights after initialisation";
 
   IDEAS.Buildings.Components.Interfaces.ZoneBus propsBus_a(
@@ -88,6 +87,16 @@ partial model PartialSurface "Partial model for building envelope component"
     "Multilayer component for simulating walls, windows and other surfaces"
     annotation (Placement(transformation(extent={{10,-10},{-10,10}})));
 
+  output Modelica.Units.SI.MassFlowRate mBA_flow_1=crackOrOperableDoor.m1_flow
+  if add_door and sim.interZonalAirFlowType <> IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None
+  "Flow outwards relative to propsBus_a, part 1"
+    annotation (Placement(visible = true, transformation(origin = {30, -52}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
+  output Modelica.Units.SI.MassFlowRate mBA_flow_2=-crackOrOperableDoor.m2_flow
+  if add_door and sim.interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts
+  "Flow outwards relative to propsBus_a, part 2"
+    annotation (Placement(visible = true, transformation(origin = {30, -52}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
+
+//protected
   Q50_parameterToConnector q50_zone(
     q50_inp=q50_internal,
     v50_surf=q50_internal*A,
@@ -102,7 +111,7 @@ partial model PartialSurface "Partial model for building envelope component"
     h_b1=-0.5*hzone_a + 0.75*hVertical + hRelSurfBot_a,
     h_a2=-0.5*hzone_a + 0.25*hVertical + hRelSurfBot_a,
     interZonalAirFlowType = sim.interZonalAirFlowType,
-    inc=inc)                                           if add_door and sim.interZonalAirFlowType <> IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None annotation (
+    inc=incInt) if add_door and sim.interZonalAirFlowType <> IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None annotation (
     Placement(visible = true, transformation(origin = {30, -52}, extent = {{-10, -10}, {10, 10}}, rotation = 0)));
   Modelica.Blocks.Sources.RealExpression AExp(y = A) "Area expression" annotation(
     Placement(transformation(origin = {0, 20}, extent = {{-10, -10}, {10, 10}})));
@@ -282,6 +291,10 @@ equation
     Documentation(revisions="<html>
 <ul>
 <li>
+August 18, 2025, by Klaas De Jonge:<br/>
+Changed <code>inc</code> to <code>incInt</code> where nececarry.
+</li>
+<li>
 January 24, 2025, by Klaas De Jonge:<br/>
 Addition of BooleanPassThrough and RealPassThrough block for v50 and use_custom_q50 and
 parameter for number of dummy connections in <code>Q50_parameterToConnector</code> to avoid translation warnings.

diff --git a/IDEAS/Buildings/Components/Interfaces/PartialZone.mo b/IDEAS/Buildings/Components/Interfaces/PartialZone.mo
@@ -17,7 +17,7 @@ model PartialZone "Building zone model"
 
   parameter Real n50(unit="1/h",min=0.01)= sim.n50 "n50 value for this zone"
    annotation(Dialog(tab="Airflow", group="Airtightness"));
-  final parameter Real n50_computed(unit="1/h",min=0.01) = if use_custom_n50 and not setq50.allSurfacesCustom then n50 else n50_int "Computed n50 value";
+  final parameter Real n50_computed(unit="1/h",min=0.01) = n50_int "Computed n50 value";
   parameter Boolean allowFlowReversal=true
     "= true to allow flow reversal in zone, false restricts to design direction (port_a -> port_b)."
     annotation(Dialog(tab="Airflow", group="Air model"));
@@ -561,6 +561,10 @@ end for;
 </html>", revisions="<html>
 <ul>
 <li>
+August 18, 2025, by Klaas De Jonge:<br/>
+Simplified <code>n50_computed</code> to <code>n50_int</code> since the if statement was a duplicate.
+</li>
+<li>
 November 11, 2024 by Lucas Verleyen:<br/>
 Change Medium to IDEAS.Media.Air and use 'constrainedby' for Modelica.Media.Interfaces.PartialMedium.
 This is for <a href=https://github.com/open-ideas/IDEAS/issues/1375>#1375</a>.