Issue1436 add pvt model #1455
Merged
Issue1436 add pvt model #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
…2975HeatLoss_SteadyState
- improve formatting - update revision history - apply same updates to PVTQuasiDynamicCollectorValidation - add Simulate and plot commands
IDEAS/Fluid/PvtCollectors/BaseClasses/ISO9806QuasiDynamicHeatLoss.mo
Outdated
Show resolved
Hide resolved
IDEAS/Fluid/PvtCollectors/Validation/PVT_UI/PVTQuasiDynamicCollectorValidation.mo
Outdated
Show resolved
Hide resolved
jelgerjansen
approved these changes
Aug 20, 2025
Contributor
|
The validation models and scripts work in Dymola (both 2022x and 2025x), but somehow the unit tests fail (see https://github.com/open-ideas/IDEAS/actions/runs/17097622920/job/48485699507). This is to be tackled in a future issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1454 and solves #1436