refactor(build): remove dreamplace build, use uv to manage release wheels#31
Merged
refactor(build): remove dreamplace build, use uv to manage release wheels#31
Conversation
Emin017
force-pushed
the
emin/remove-dreamplace-build
branch
from
31c5ec1 to
ecf184c
Compare
Emin017
force-pushed
the
emin/remove-dreamplace-build
branch
from
4b4cf15 to
e331180
Compare
Emin017
changed the title
There was a problem hiding this comment.
Pull request overview
Refactors the ECOS Studio build/release workflow to stop building ECC/DreamPlace wheels locally and instead consume pinned GitHub Release wheels managed via uv (with a corresponding simplification of scripts/docs).
Changes:
- Switch
ecos/serverdependencies to pinned alpha release wheels viauvsources, and add an explicittorchdependency. - Remove local wheel build/install steps from the server preparation script and the root
Makefilebuild pipeline; add ause-local-ecchelper target for development. - Update documentation to describe the new “locked release wheels” workflow.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ecos/server/pyproject.toml |
Pins ECC-related dependencies to GitHub Release wheels via uv sources and constrains uv environments. |
ecos/scripts/prepare-ecos-server.sh |
Removes local wheel build logic; relies on uv sync --frozen for the server venv. |
ecos/README.md |
Updates build/wheels documentation to the new release-wheel-based flow. |
README.md |
Updates top-level wording to reflect locked release wheels in the release build. |
Makefile |
Removes wheel build/install targets, adds use-local-ecc, and simplifies release build steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
README.md:52
- The comment says
make setupinitializes the "ECC environment", but thesetuptarget now only updates submodules and writes.setup-done(the uv environment is created inmake dev/make build). Consider rewording this line to avoid implying that ECC/server dependencies are installed duringmake setup.
# Setup (init submodules, PDK, and ECC environment)
make setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… present Adds a _download_dreamplace_wheel target as an order-only prerequisite for $(BUNDLE_TAR). If no ecc_dreamplace wheel exists locally, fetches the latest from GitHub Releases via curl (no auth needed for public repos). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Updates to ecc branch emin/remove-dreamplace-build which deduplicates dreamplace build infrastructure via bazel_dep + local_path_override. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Emin017
force-pushed
the
emin/remove-dreamplace-build
branch
from
ce32cc7 to
29587e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces ECOS Studio CI/CD build time by removing the need for the
ecos-studiopipeline to build ECC and DreamPlace wheels from source during setup and release packaging.Instead, the server environment now consumes pinned GitHub Release wheels for
ecc,ecc-dreamplace, andecc-toolsthroughecos/server/pyproject.tomlanduv.lock.CI/CD Impact
Before this change, ECOS Studio builds had to spend time compiling and repairing native wheel artifacts as part of the repository's own build flow.
After this change, the release build path is shorter:
This keeps expensive native package builds out of the ECOS Studio CI/CD path and lets this repository focus on assembling and validating the application bundle.
Changes
Notes
The server build environment is intentionally limited to Linux x86_64 with glibc >= 2.34 for now, matching the currently published native wheel artifacts for ecc-dreamplace and ecc-tools.