Open
Conversation
Emin017
requested changes
Apr 16, 2026
| @@ -1,21 +1,5 @@ | |||
| build --disk_cache=~/.cache/bazel-disk | |||
Collaborator
There was a problem hiding this comment.
Why does this file require so many changes?
| @@ -0,0 +1,28 @@ | |||
| #!/usr/bin/env python | |||
Collaborator
There was a problem hiding this comment.
Please add this functionality to the Python API server.
Collaborator
There was a problem hiding this comment.
Were any changes made in ecc? If so, please also open a PR in the ecc repository.
Collaborator
|
Thank you for your contribution! But I have a few change requests for this PR. |
Collaborator
|
We may indeed need support for multiple PDKs, but we haven’t yet figured out the best way to integrate and support them, as this would increase the overall complexity of the software. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we successfully expanded the platform's multi-foundry capabilities by implementing auto-detection logic for IHP SG13G2 and GF180MCU within the Vue.js frontend, while simultaneously updating the Python backend with specific PDK dataclasses for routing physical design rules like Tech LEFs and cell definitions. To streamline the environment setup, we resolved repository access hurdles by standardizing submodule protocols and introduced a robust install_pdks.py script that automates the version-locked installation of four major PDKs (ICS55, IHP, Sky130, and GF180) alongside the essential OSS CAD Suite binaries.