Skip to content

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Apr 16, 2025

Ticket: #36413

  • In this PR we are moving Video Block JS into xmodule/assets as discussed in this readme
  • Replacing RequireJS with ES6 import/export

How to test:

  1. Run npm run webpack-dev in lms shell (not worker shell but lms shell)
  2. Open the Video XBlock in the LMS and check logs in the browser console for the PR working.

JS files refactoring details:

diffchecker can be used (on real-time-diff) to see the accurate refactoring changes.

# Source JS File (RequireJS pattern) Destination JS File (Vanilla JS)
1 00_i18n.js i18n.js
2 00_async_process.js async_process.js
3 00_iterator.js iterator.js
4 00_component.js component.js
5 09_bumper.js video_bumper.js
6 00_sjson.js sjson.js
7 08_video_auto_advance_control.js video_auto_advance_control.js
8 02_html5_hls_video.js html5_hls_video.js
9 04_video_control.js video_control.js
10 05_video_quality_control.js video_quality_control.js
11 00_resizer.js resizer.js
12 09_completion.js video_completion_handler.js
13 01_initialize.js initialize.js
14 02_html5_video.js html5_video.js
15 03_video_player.js video_player.js
16 04_video_full_screen.js video_full_screen.js
17 06_video_progress_slider.js video_progress_slider.js
18 07_video_volume_control.js video_volume_control.js
19 08_video_speed_control.js video_speed_control.js
20 09_events_bumper_plugin.js events_bumper_plugin.js
21 09_events_plugin.js events_plugin.js
22 09_play_pause_control.js play_pause_control.js
23 09_play_placeholder.js play_placeholder.js
24 09_play_skip_control.js play_skip_control.js
25 09_poster.js poster.js
26 09_save_state_plugin.js save_state_plugin.js
27 09_skip_control.js skip_control.js
28 09_video_caption.js video_caption.js
29 10_commands.js commands.js
30 025_focus_grabber.js focus_grabber.js
31 035_video_accessible_menu.js video_accessible_menu.js
32 036_video_social_sharing.js video_social_sharing.js
33 037_video_transcript_feedback.js video_transcript_feedback.js
34 095_video_context_menu.js video_context_menu.js

Child PR's

@farhan farhan self-assigned this Apr 16, 2025
@farhan farhan linked an issue Apr 16, 2025 that may be closed by this pull request
@farhan farhan changed the title Move Video Block JS into xmodule/assets Replace Video Block 'RequireJS' with ES6 import/export Apr 16, 2025
@farhan farhan requested a review from ahmad-arbisoft April 16, 2025 13:00
@farhan farhan changed the title Replace Video Block 'RequireJS' with ES6 import/export Move Video Block JS into xmodule/assets refactoring on ES6 import/export Apr 17, 2025
@farhan farhan force-pushed the convert-video-block-js-to-vanilla branch from f8c2f02 to e05bafd Compare April 17, 2025 07:29
@farhan farhan force-pushed the convert-video-block-js-to-vanilla branch from 00df601 to 325fb2b Compare April 22, 2025 10:16
@farhan
Copy link
Contributor Author

farhan commented Apr 24, 2025

Closing the PR on account of #36595

Following the better approach to refactor after taking experience from it

@farhan farhan closed this Apr 24, 2025
@farhan farhan changed the title Move Video Block JS into xmodule/assets refactoring on ES6 import/export [Archived] Move Video Block JS into xmodule/assets refactoring on ES6 import/export Apr 26, 2025
@farhan farhan deleted the convert-video-block-js-to-vanilla branch January 6, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants