-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Archived] Move Video Block JS into xmodule/assets refactoring on ES6 import/export #36527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import/export
ahmad-arbisoft
approved these changes
Apr 16, 2025
import/exportf8c2f02 to
e05bafd
Compare
ahmad-arbisoft
approved these changes
Apr 18, 2025
00df601 to
325fb2b
Compare
Contributor
Author
|
Closing the PR on account of #36595 Following the better approach to refactor after taking experience from it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #36413
import/exportHow to test:
npm run webpack-devin lms shell (not worker shell but lms shell)JS files refactoring details:
diffchecker can be used (on real-time-diff) to see the accurate refactoring changes.
Child PR's