Migrating from RequireJS to ES6 Modules #36595

farhan · 2025-04-24T13:34:15Z

In this PR we are moving Video Block JS into xmodule/assets as discussed in this readme
Replacing RequireJS with ES6 import/export

JS files refactoring details:

Reviewer can open the second or next commits to review the changes as the first commit contains the old code.
diffchecker can be used (on real-time-diff) to see the accurate refactoring changes.

#	Source JS File (RequireJS pattern)	Destination JS File (Vanilla JS)
1	00_i18n.js	00_i18n.js
2	00_async_process.js	00_async_process.js
3	09_poster.js	09_poster.js
4	035_video_accessible_menu.js	035_video_accessible_menu.js
5	00_iterator.js	00_iterator.js
6	09_skip_control.js	09_skip_control.js
7	09_play_placeholder.js	09_play_placeholder.js
8	00_component.js	00_component.js
9	09_play_skip_control.js	09_play_skip_control.js
10	09_play_pause_control.js	09_play_pause_control.js
11	036_video_social_sharing.js	036_video_social_sharing.js
12	00_video_storage.js	00_video_storage.js
13	10_commands.js	10_commands.js
14	09_bumper.js	09_bumper.js
15	09_events_bumper_plugin.js	09_events_bumper_plugin.js
16	00_sjson.js	00_sjson.js
17	08_video_auto_advance_control.js	08_video_auto_advance_control.js
18	09_save_state_plugin.js	09_save_state_plugin.js
19	025_focus_grabber.js	025_focus_grabber.js
20	02_html5_hls_video.js	02_html5_hls_video.js
21	09_events_plugin.js	09_events_plugin.js
22	04_video_control.js	04_video_control.js
23	05_video_quality_control.js	05_video_quality_control.js
24	00_resizer.js	00_resizer.js
25	09_completion.js	09_completion.js
26	10_main.js	10_main.js
27	037_video_transcript_feedback.js	037_video_transcript_feedback.js
28	04_video_full_screen.js	04_video_full_screen.js
29	06_video_progress_slider.js	06_video_progress_slider.js
30	02_html5_video.js	02_html5_video.js
31	08_video_speed_control.js	08_video_speed_control.js
32	07_video_volume_control.js	07_video_volume_control.js
33	095_video_context_menu.js	095_video_context_menu.js
34	01_initialize.js	01_initialize.js
35	03_video_player.js	03_video_player.js
36	09_video_caption.js	09_video_caption.js
37	time.js	time.js

How to test:

Check out the branch
run npm run webpack-dev
Do Hard cache reload of the browser

Old archived PR

open-craft-grove · 2025-05-05T06:52:48Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-05-05T08:07:23Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-05-05T10:05:49Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-05-05T10:40:18Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2025-05-05T17:14:33Z

Wow, great to see this. Question: why are the old .js files not deleted as part of this PR?

open-craft-grove · 2025-05-06T07:22:34Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

xmodule/video_block/video_block.py

xmodule/assets/video/public/js/utils/time.js

xmodule/assets/video/public/js/09_skip_control.js

open-craft-grove · 2025-05-06T16:07:26Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

ahmad-arbisoft

LGTM

farhan · 2025-05-07T09:09:32Z

Wow, great to see this. Question: why are the old .js files not deleted as part of this PR?

@bradenmacdonald
Thanks!
I was thinking to delete old JS files in separate PR, I think it makes better sense to delete them within this PR.
On the way.

open-craft-grove · 2025-09-17T11:37:42Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

xmodule/assets/video/public/js/09_events_plugin.js

open-craft-grove · 2025-09-30T07:27:29Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-09-30T10:58:16Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-10-03T12:34:22Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

- Move Video Block JS files from xmodule/js/src/video/ to xmodule/assets/video/public/js/ - Update JavaScript files from RequireJS to ES6 import/export

open-craft-grove · 2025-10-03T13:47:09Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

* fix: enable and fix webpack karma js tests for video block

open-craft-grove · 2025-10-04T07:08:21Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

salman2013

LGTM

open-craft-grove · 2025-10-06T12:02:50Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick

Awesome 🎉

Before merging, can you confirm that you have manually tested both the CMS and LMS views of the video block?

package.json

Co-authored-by: Kyle McCormick <kyle@axim.org>

farhan · 2025-10-06T14:27:41Z

@kdmccormick
Yes we have tested the PR manually.

open-craft-grove · 2025-10-06T15:12:58Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-10-07T14:16:52Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

farhan mentioned this pull request Apr 24, 2025

[Archived] Move Video Block JS into xmodule/assets refactoring on ES6 import/export #36527

Closed

farhan force-pushed the farhan/move-video-js-to-assets branch 9 times, most recently from 1419e98 to 890e51f Compare April 29, 2025 13:07

farhan force-pushed the farhan/move-video-js-to-assets branch from e1d1c03 to 61d0116 Compare May 2, 2025 18:49

farhan force-pushed the farhan/original-js-code branch from d26b6c7 to 613e9f6 Compare May 2, 2025 18:50

farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label May 2, 2025

farhan changed the base branch from farhan/original-js-code to master May 5, 2025 05:47

farhan marked this pull request as ready for review May 5, 2025 05:49

farhan closed this May 5, 2025

farhan reopened this May 5, 2025

farhan force-pushed the farhan/move-video-js-to-assets branch 2 times, most recently from 0802d3f to 0b85563 Compare May 5, 2025 09:57

ahmad-arbisoft suggested changes May 6, 2025

View reviewed changes

xmodule/video_block/video_block.py Show resolved Hide resolved

xmodule/video_block/video_block.py Show resolved Hide resolved

xmodule/assets/video/public/js/utils/time.js Show resolved Hide resolved

xmodule/assets/video/public/js/09_skip_control.js Show resolved Hide resolved

farhan requested a review from ahmad-arbisoft May 6, 2025 13:55

ahmad-arbisoft approved these changes May 7, 2025

View reviewed changes

salman2013 mentioned this pull request Sep 15, 2025

Enable webpack JS tests for xmodule #37274

Closed

salman2013 requested changes Sep 24, 2025

View reviewed changes

xmodule/assets/video/public/js/09_events_plugin.js Outdated Show resolved Hide resolved

chore: Original JS files copied from xmodule/js/src/video directory

0f17c98

farhan force-pushed the farhan/move-video-js-to-assets branch from 4f66eb1 to 0d2a43f Compare September 30, 2025 10:07

farhan force-pushed the farhan/move-video-js-to-assets branch from b1a2c4c to 9b4a963 Compare October 3, 2025 12:45

refactor: Update and migrate Video Block JS files into xmodule/assets

0d2f3d5

- Move Video Block JS files from xmodule/js/src/video/ to xmodule/assets/video/public/js/ - Update JavaScript files from RequireJS to ES6 import/export

farhan force-pushed the farhan/move-video-js-to-assets branch from 9b4a963 to cf26705 Compare October 3, 2025 12:51

test: Enable Karma Js tests (#37351)

d379540

* fix: enable and fix webpack karma js tests for video block

farhan force-pushed the farhan/move-video-js-to-assets branch from cf26705 to d379540 Compare October 4, 2025 06:20

salman2013 approved these changes Oct 6, 2025

View reviewed changes

Merge branch 'master' into farhan/move-video-js-to-assets

a0765d3

kdmccormick removed the blocked by other work PR cannot be finished until other work is complete label Oct 6, 2025

kdmccormick approved these changes Oct 6, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update package.json

af8d3e1

Co-authored-by: Kyle McCormick <kyle@axim.org>

farhan closed this Oct 6, 2025

farhan reopened this Oct 6, 2025

Merge branch 'master' into farhan/move-video-js-to-assets

8280662

farhan merged commit 5c759f1 into master Oct 7, 2025
63 of 65 checks passed

farhan deleted the farhan/move-video-js-to-assets branch October 7, 2025 14:01

bradenmacdonald mentioned this pull request Oct 8, 2025

revert: chore: upgrade jQuery UI to version 1.14.1 #37449

Merged

Migrating from RequireJS to ES6 Modules #36595

Migrating from RequireJS to ES6 Modules #36595

Uh oh!

Conversation

farhan commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JS files refactoring details:

How to test:

Old archived PR

Uh oh!

open-craft-grove commented May 5, 2025

Uh oh!

open-craft-grove commented May 5, 2025

Uh oh!

open-craft-grove commented May 5, 2025

Uh oh!

open-craft-grove commented May 5, 2025

Uh oh!

bradenmacdonald commented May 5, 2025

Uh oh!

open-craft-grove commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

open-craft-grove commented May 6, 2025

Uh oh!

ahmad-arbisoft left a comment

Choose a reason for hiding this comment

Uh oh!

farhan commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

open-craft-grove commented Sep 17, 2025

Uh oh!

Uh oh!

open-craft-grove commented Sep 30, 2025

Uh oh!

open-craft-grove commented Sep 30, 2025

Uh oh!

open-craft-grove commented Oct 3, 2025

Uh oh!

open-craft-grove commented Oct 3, 2025

Uh oh!

open-craft-grove commented Oct 4, 2025

Uh oh!

salman2013 left a comment

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Oct 6, 2025

Uh oh!

kdmccormick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

farhan commented Oct 6, 2025

Uh oh!

open-craft-grove commented Oct 6, 2025

Uh oh!

Uh oh!

open-craft-grove commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

farhan commented Apr 24, 2025 •

edited

Loading

farhan commented May 7, 2025 •

edited

Loading