Skip to content

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Sep 25, 2025

Ticket

Relevant edx-platform test cases: PR

Testing Notes:

First checkout the branch on the first commit and make sure all the original code has been copied correctly.

Then open the second commit and review the changes.

Enable Hide Whitespace from the settings, it will help in reviewing the code.

Extracted Video XBlock can be manually tested on the local machine setup up.

Pending Stories in Video XBlock Extraction:

@farhan farhan changed the title Farhan/video xblock extraction Core Video XBlock extracted from edx-platform Sep 25, 2025
@farhan farhan requested a review from Copilot September 26, 2025 12:52
@farhan farhan marked this pull request as draft September 26, 2025 12:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts the Core Video XBlock from edx-platform into a standalone xblocks-contrib package. The extraction enables the Video XBlock to be used independently of edx-platform while maintaining full video playback functionality.

  • Extracts complete Video XBlock implementation with all core video features
  • Migrates extensive JavaScript frontend codebase for video player controls
  • Includes comprehensive video handling utilities and transcript management

Reviewed Changes

Copilot reviewed 63 out of 67 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
xblocks_contrib/video/video.py Main Video XBlock implementation with student/studio views and configuration
xblocks_contrib/video/video_xfields.py Video-specific field definitions including RelativeTime for timestamps
xblocks_contrib/video/video_handlers.py Request handlers for video operations and transcript management
xblocks_contrib/video/video_utils.py Video utility functions for URL rewriting and metadata handling
xblocks_contrib/video/transcripts_utils.py Comprehensive transcript processing and management utilities
xblocks_contrib/video/static/js/src/10_main.js Main JavaScript entry point for video player initialization
xblocks_contrib/video/webpack.*.config.js Webpack build configurations for development and production
xblocks_contrib/video/templates/video.html Video block HTML template with player controls and UI
xblocks_contrib/video/tests/test_toggles.py Unit tests for video configuration toggle functions
Multiple JS modules Complete video player frontend implementation including captions, controls, and plugins

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@farhan farhan force-pushed the farhan/video-xblock-extraction branch 5 times, most recently from d578970 to 2d813ae Compare October 1, 2025 08:12
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 7 times, most recently from 2807f54 to 8d34dc7 Compare October 2, 2025 11:31
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 4 times, most recently from 635cf94 to ca10695 Compare October 10, 2025 06:20
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 5 times, most recently from 8848db0 to 86b1417 Compare November 6, 2025 12:20
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 8 times, most recently from a7e8e76 to 8c585cd Compare January 8, 2026 07:48
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 4 times, most recently from 28100a9 to 8ec6d2e Compare January 16, 2026 13:22
@farhan farhan force-pushed the farhan/video-xblock-extraction branch 2 times, most recently from eca7fa3 to 554182b Compare January 19, 2026 13:39
@openedx openedx deleted a comment from Copilot AI Jan 19, 2026
@openedx openedx deleted a comment from Copilot AI Jan 19, 2026
@openedx openedx deleted a comment from Copilot AI Jan 19, 2026
@openedx openedx deleted a comment from Copilot AI Jan 19, 2026
@openedx openedx deleted a comment from Copilot AI Jan 19, 2026
@farhan farhan force-pushed the farhan/video-xblock-extraction branch from 554182b to 88e824e Compare January 19, 2026 13:53
@farhan farhan marked this pull request as ready for review January 19, 2026 14:51
This commit contains original code copied from edx-platform.
Purpose of keeping the first commit with original code is to get help in the review process.
Reviewer just needs to open the second commit and code changes will be clearly visible.
@salman2013
Copy link
Contributor

@farhan One suggestion, if it’s easy to do, as you mentioned, we currently need to check out the first commit and then the second commit to compare the changes. I think it would be better to create two separate PRs one base PR with the first commit, and a second PR with the second commit. This would improve visibility into the code changes and likely reduce the review cycle, since some of the changes have already been reviewed and merged in edx-platform.

@farhan
Copy link
Contributor Author

farhan commented Jan 23, 2026

Closing on account of
#142

@farhan farhan closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants