-
Notifications
You must be signed in to change notification settings - Fork 4
Core Video XBlock extracted from edx-platform #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extracts the Core Video XBlock from edx-platform into a standalone xblocks-contrib package. The extraction enables the Video XBlock to be used independently of edx-platform while maintaining full video playback functionality.
- Extracts complete Video XBlock implementation with all core video features
- Migrates extensive JavaScript frontend codebase for video player controls
- Includes comprehensive video handling utilities and transcript management
Reviewed Changes
Copilot reviewed 63 out of 67 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| xblocks_contrib/video/video.py | Main Video XBlock implementation with student/studio views and configuration |
| xblocks_contrib/video/video_xfields.py | Video-specific field definitions including RelativeTime for timestamps |
| xblocks_contrib/video/video_handlers.py | Request handlers for video operations and transcript management |
| xblocks_contrib/video/video_utils.py | Video utility functions for URL rewriting and metadata handling |
| xblocks_contrib/video/transcripts_utils.py | Comprehensive transcript processing and management utilities |
| xblocks_contrib/video/static/js/src/10_main.js | Main JavaScript entry point for video player initialization |
| xblocks_contrib/video/webpack.*.config.js | Webpack build configurations for development and production |
| xblocks_contrib/video/templates/video.html | Video block HTML template with player controls and UI |
| xblocks_contrib/video/tests/test_toggles.py | Unit tests for video configuration toggle functions |
| Multiple JS modules | Complete video player frontend implementation including captions, controls, and plugins |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d578970 to
2d813ae
Compare
2807f54 to
8d34dc7
Compare
635cf94 to
ca10695
Compare
8848db0 to
86b1417
Compare
a7e8e76 to
8c585cd
Compare
28100a9 to
8ec6d2e
Compare
eca7fa3 to
554182b
Compare
554182b to
88e824e
Compare
This commit contains original code copied from edx-platform. Purpose of keeping the first commit with original code is to get help in the review process. Reviewer just needs to open the second commit and code changes will be clearly visible.
88e824e to
de0c3d6
Compare
|
@farhan One suggestion, if it’s easy to do, as you mentioned, we currently need to check out the first commit and then the second commit to compare the changes. I think it would be better to create two separate PRs one base PR with the first commit, and a second PR with the second commit. This would improve visibility into the code changes and likely reduce the review cycle, since some of the changes have already been reviewed and merged in edx-platform. |
|
Closing on account of |
Ticket
Relevant edx-platform test cases: PR
Testing Notes:
First checkout the branch on the first commit and make sure all the original code has been copied correctly.
Then open the second commit and review the changes.
Enable
Hide Whitespacefrom the settings, it will help in reviewing the code.Extracted Video XBlock can be manually tested on the local machine setup up.
Pending Stories in Video XBlock Extraction: