OCPBUGS-70352: handled dynamic secret for remote alertmanager by mvazquezc · Pull Request #567 · openshift-kni/telco-reference

mvazquezc · 2026-01-27T20:06:03Z

No description provided.

openshift-ci · 2026-01-27T20:06:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvazquezc
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-01-27T20:06:13Z

Hi @mvazquezc. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

abraham2512 · 2026-01-28T13:50:59Z

...figuration/source-crs/cluster-tuning/monitoring-configuration/ReduceMonitoringFootprint.yaml

        bearerToken:
          key: token
-          name: observability-alertmanager-accessor
+          name: {{ if (lookup "v1" "Namespace" "" "open-cluster-management-addon-observability") }}{{ (regexFind "hub-cluster-id(.*)" ((fromSecret "open-cluster-management-addon-observability" "hub-info-secret" "hub-info.yaml") | base64dec)) | replace "hub-cluster-id: " "observability-alertmanager-accessor-" }}{{ else }}observability-alertmanager-accessor{{ end }}


Is it possible to do a quick test on acm 2.14 that things are in order?
I'm curious what happens to this regexFind "hub-cluster-id(.*)" when its not available in the hub-info-secret in acm-2.14.
Does it go to the else block or return an empty string, making a secret name observability-alertmanager-accessor- which would be incorrect

Will test on 2.14 and report back results.

mvazquezc · 2026-01-29T14:45:37Z

This has been validated in 2.14 and 2.15.

2.14

oc --kubeconfig abi -n openshift-monitoring get cm cluster-monitoring-config -o yaml
apiVersion: v1
data:
  config.yaml: |-
    alertmanagerMain:
      enabled: false
    telemeterClient:
      enabled: false
    nodeExporter:
      collectors:
        buddyinfo: {}
        cpufreq: {}
        ksmd: {}
        mountstats: {}
        netclass: {}
        netdev: {}
        processes: {}
        systemd: {}
        tcpstat: {}
    prometheusK8s:
      additionalAlertmanagerConfigs:
      - apiVersion: v2
        bearerToken:
          key: token
          name: observability-alertmanager-accessor
        scheme: https
        staticConfigs: [alertmanager-open-cluster-management-observability.apps.hub.5g-deployment.lab]
        tlsConfig:
          ca:
            key: service-ca.crt
            name: hub-alertmanager-router-ca
          insecureSkipVerify: false
      externalLabels:
        managed_cluster: 304779e6-6785-452b-a61c-670eafc2649c
      retention: 24h
kind: ConfigMap
metadata:
  annotations:
    ran.openshift.io/ztp-deploy-wave: "1"
  creationTimestamp: "2026-01-29T12:05:02Z"
  name: cluster-monitoring-config
  namespace: openshift-monitoring
  resourceVersion: "23301"
  uid: 03266338-772e-4b84-86be-8bae37b1c2bb

2.15

apiVersion: v1
data:
  config.yaml: |
    alertmanagerMain:
      enabled: false
    telemeterClient:
      enabled: false
    nodeExporter:
      collectors:
        buddyinfo: {}
        cpufreq: {}
        ksmd: {}
        mountstats: {}
        netclass: {}
        netdev: {}
        processes: {}
        systemd: {}
        tcpstat: {}
    prometheusK8s:
      additionalAlertmanagerConfigs:
      - apiVersion: v2
        bearerToken:
          key: token
          name: observability-alertmanager-accessor-1d70fd5186d445e4883
        scheme: https
        staticConfigs: [alertmanager-open-cluster-management-observability.apps.hub.5g-deployment.lab]
        tlsConfig:
          ca:
            key: service-ca.crt
            name: hub-alertmanager-router-ca-1d70fd5186d445e4883
          insecureSkipVerify: false
      externalLabels:
        managed_cluster: f9be5ddd-3497-42cb-ad10-7159011f3fcb
      retention: 24h
kind: ConfigMap
metadata:
  annotations:
    ran.openshift.io/ztp-deploy-wave: "1"
  creationTimestamp: "2026-01-29T14:30:31Z"
  name: cluster-monitoring-config
  namespace: openshift-monitoring
  resourceVersion: "13441"
  uid: 587851bd-1a3f-4020-ac90-bfb6f495a28e

abraham2512 · 2026-01-29T17:35:41Z

/lgtm

abraham2512 · 2026-01-29T17:43:01Z

Thanks for updating and verifying the fix with 2.14 and 2.15 @mvazquezc

abraham2512 · 2026-01-29T17:43:21Z

To pass CI, you also need to update this in the kube-compare reference here
https://github.com/openshift-kni/telco-reference/blob/main/telco-ran/configuration/kube-compare-reference/cluster-tuning/monitoring-configuration/ReduceMonitoringFootprint.yaml

abraham2512 · 2026-01-29T17:47:26Z

We'd also need this same change reciprocated in the Core config, here
https://github.com/openshift-kni/telco-reference/blob/main/telco-core/configuration/reference-crs/optional/other/monitoring-config-cm.yaml

abraham2512 · 2026-01-29T20:47:50Z

/ok-to-test

abraham2512 · 2026-01-29T20:48:35Z

...ube-compare-reference/cluster-tuning/monitoring-configuration/ReduceMonitoringFootprint.yaml

          ca:
            key: service-ca.crt
-            name: hub-alertmanager-router-ca
+            name: (<hub_alertmanager_router_ca>.*)


typo, missing ?

Signed-off-by: Mario Vazquez <mavazque@redhat.com>

openshift-ci-robot · 2026-01-29T20:52:56Z

@mvazquezc: This pull request references Jira Issue OCPBUGS-70352, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

abraham2512 · 2026-01-29T20:53:41Z

/jira refresh

openshift-ci-robot · 2026-01-29T20:53:48Z

@abraham2512: This pull request references Jira Issue OCPBUGS-70352, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

abraham2512 · 2026-01-29T20:54:26Z

/cc @irinamihai @imiller0

abraham2512 · 2026-01-29T22:56:14Z

/lgtm

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2026

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2026

mvazquezc mentioned this pull request Jan 27, 2026

Added dynamic secret name resolution for hub's altermanager #566

Closed

mvazquezc marked this pull request as ready for review January 28, 2026 13:42

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026

openshift-ci bot requested review from ffromani and sabbir-47 January 28, 2026 13:42

abraham2512 reviewed Jan 28, 2026

View reviewed changes

mvazquezc force-pushed the main branch from 5f9dd61 to c3805f8 Compare January 29, 2026 12:33

openshift-ci bot assigned abraham2512 Jan 29, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

mvazquezc force-pushed the main branch from c3805f8 to a8ce21d Compare January 29, 2026 20:37

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2026

abraham2512 reviewed Jan 29, 2026

View reviewed changes

handled dynamic secret for remote alertmanager

b47995f

Signed-off-by: Mario Vazquez <mavazque@redhat.com>

mvazquezc force-pushed the main branch from a8ce21d to b47995f Compare January 29, 2026 20:51

mvazquezc changed the title ~~handled dynamic secret for remote alertmanager~~ OCPBUGS-70352: handled dynamic secret for remote alertmanager Jan 29, 2026

openshift-ci bot requested review from imiller0 and irinamihai January 29, 2026 20:54

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026

Comments

Conversation

mvazquezc commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

abraham2512 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

mvazquezc Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

mvazquezc commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

abraham2512 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

openshift-ci-robot commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

abraham2512 commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abraham2512 commented Jan 29, 2026 •

edited

Loading