SPLAT-2296: Installer - disk setup via mco,ign #1805
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
|
||
| ## Proposal | ||
|
|
||
| The core of this proposal is to introduce new structures within the machine pool API that allow users to declare additional disks and their intended use. The installer will then interpret these declarations to generate the appropriate `storage` and `systemd` sections in the ignition config. |
There was a problem hiding this comment.
Just to clarify this point, do these APIs propagate to the cluster post-install? Or is it just used to generate installer-specific ignition data.
Another way to put it would be whether the user has any say in modifying this configuration post-install via any API field or would they have to manually modify user-data secrets, since I presume that it will end up on the cluster's machine-api namespaced secrets
There was a problem hiding this comment.
I think this question still applies? Apologies if we had discussed this separately.
jcpowermac
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jcpowermac: This pull request references SPLAT-2296 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This enhancement needs to be updated after meeting with @yuqi-zhang. |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@jcpowermac: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
removed
the
lifecycle/rotten
|
@jcpowermac: This pull request references SPLAT-2296 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcpowermac: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jcpowermac
force-pushed
the
multi-disk-setup
branch
from
1e62d51 to
bf495e1
Compare
|
I had claude take the bug and installer implementation pr to update this enhancement. I need to review what it added. |
This enhancement describes the implementation details for adding the ability in the installer to create machine configs that will be used to setup disks partitions, formatting and mounting day 0.
jcpowermac
force-pushed
the
multi-disk-setup
branch
from
bf495e1 to
146ae2c
Compare
|
@jcpowermac: This pull request references SPLAT-2296 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcpowermac: This pull request references SPLAT-2296 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jcpowermac
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @vr4manta @patrickdillon @yuqi-zhang |
|
@jcpowermac: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| ## Proposal | ||
|
|
||
| The core of this proposal is to introduce new structures within the machine pool API that allow users to declare additional disks and their intended use. The installer will then interpret these declarations to generate the appropriate `storage` and `systemd` sections in the ignition config. |
There was a problem hiding this comment.
I think this question still applies? Apologies if we had discussed this separately.
|
|
||
| #### Hypershift / Hosted Control Planes | ||
|
|
||
| This feature can be applied to Hypershift / Hosted Control Planes for worker nodes. The hosted control plane itself runs as pods and does not use this disk setup mechanism. Worker nodes in hosted clusters can be configured with disk setup for swap or user-defined storage needs. |
There was a problem hiding this comment.
Not sure on this point. I don't think hosted clusters are created via the installer at all? Are you proposing that the user use installer to generate their nodepool-specific machineconfigs, apply them to new nodepools by hand, and have the MCO reconcile?
|
|
||
| ### Goals | ||
|
|
||
| * Enable the installer to accept configurations for multiple disks per machine pool. |
There was a problem hiding this comment.
I assume this machinepool is in reference to the CAPI machinepool object?
The MCO doesn't 1-to-1 map MachineConfigPools to MachineSets today by design, and it probably wouldn't map 1-to-1 to machinepools once they're implemented. Could you help me understand how we would generate the MachineConfig resources mentioned later?
There was a problem hiding this comment.
Sorry @yuqi-zhang I think Claude hallucinated some updates. When I am back in the office I will review again. Thanks for the look!
6 participants
Changes
This enhancement describes the implementation
details for adding the ability in the installer
to create machine configs that will be used
to setup disks partitions, formatting and
mounting day 0.
Additional PRs
Co-Authored-By: Claude noreply@anthropic.com