Skip to content

Conversation

@jcpowermac
Copy link
Contributor

This commit adds e2e tests for the azure
data disk feature gate.

Assisted with Claude

@openshift-ci openshift-ci bot requested review from chrischdi and mdbooth October 27, 2025 17:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

@jcpowermac: The following commands are available to trigger required jobs:

/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test goimports
/test golint
/test govet
/test images
/test okd-scos-images
/test unit
/test verify-crds-sync
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-operator-techpreview
/test e2e-azure-manual-oidc
/test e2e-azure-operator
/test e2e-azure-ovn
/test e2e-gcp-operator
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-upgrade
/test e2e-nutanix
/test e2e-openstack
/test e2e-vsphere-host-groups-ovn-techpreview
/test e2e-vsphere-operator
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-multi-vcenter
/test e2e-vsphere-ovn-serial
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-techpreview-serial
/test e2e-vsphere-ovn-upgrade
/test e2e-vsphere-static-ovn
/test okd-scos-e2e-aws-ovn
/test regression-clusterinfra-aws-ipi-mapi

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-api-operator-main-e2e-aws-operator
pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn
pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn-upgrade
pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi
pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-virtualmedia
pull-ci-openshift-machine-api-operator-main-goimports
pull-ci-openshift-machine-api-operator-main-golint
pull-ci-openshift-machine-api-operator-main-govet
pull-ci-openshift-machine-api-operator-main-images
pull-ci-openshift-machine-api-operator-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-machine-api-operator-main-okd-scos-images
pull-ci-openshift-machine-api-operator-main-unit
pull-ci-openshift-machine-api-operator-main-verify-crds-sync
pull-ci-openshift-machine-api-operator-main-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 27, 2025

Need to add an optional azure techpreview job

@jcpowermac
Copy link
Contributor Author

openshift/release#70727

@damdo
Copy link
Member

damdo commented Oct 28, 2025

@damdo
Copy link
Member

damdo commented Oct 28, 2025

/assign @sunzhaohua2 @huali9 @miyadav

@sunzhaohua2
Copy link
Contributor

@shellyyang1989 is the MAPI E2E need to write to the cluster-api-actuator-pkg repo?

@jcpowermac thank you to help add machine api e2e, I don't quite understand why this feature requires a techpreview job, and it would be better if add testing of different deletion policies (delete and detach).

@jcpowermac
Copy link
Contributor Author

@sunzhaohua2 because the feature is currently in tech preview and we need to have at least 5 tests to promote to ga.

@jcpowermac
Copy link
Contributor Author

/cc @jinyunma

@shellyyang1989
Copy link

is the MAPI E2E need to write to the cluster-api-actuator-pkg repo?

For long term, we should use the unified test suite in cluster-api-actuator-pkg to cover both MAPI and CAPI. Given the framework is not ready, it looks fine to me to place the mapi e2e here. After the framework is done, we can migrate the tests to cluster-api-actuator-pkg.

@sunzhaohua2
Copy link
Contributor

https://issues.redhat.com/browse/SPLAT-2352

@sunzhaohua2 because the feature is currently in tech preview and we need to have at least 5 tests to promote to ga.

Thanks, got it. I was just testing these on day2 and don't need a tech preview cluster. These tests looks good to me.

@jcpowermac
Copy link
Contributor Author

https://issues.redhat.com/browse/SPLAT-2352

@sunzhaohua2 because the feature is currently in tech preview and we need to have at least 5 tests to promote to ga.

Thanks, got it. I was just testing these on day2 and don't need a tech preview cluster. These tests looks good to me.

@sunzhaohua2
We need tech preview because the installer has a feature flag for this, and we need to test while installing.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
This commit adds e2e tests for the azure
data disk feature gate.

Assisted with Claude
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3c65862 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn 3c65862 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade 3c65862 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-virtualmedia 3c65862 link true /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-operator 3c65862 link true /test e2e-aws-operator
ci/prow/e2e-metal-ipi 3c65862 link true /test e2e-metal-ipi
ci/prow/okd-scos-images 3c65862 link true /test okd-scos-images
ci/prow/e2e-metal-ipi-ovn-ipv6 3c65862 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/images 3c65862 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants