-
Notifications
You must be signed in to change notification settings - Fork 228
Add mapi azure datadisk e2e #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@jcpowermac: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Need to add an optional azure techpreview job |
|
/assign @sunzhaohua2 @huali9 @miyadav |
|
@shellyyang1989 is the MAPI E2E need to write to the cluster-api-actuator-pkg repo? @jcpowermac thank you to help add machine api e2e, I don't quite understand why this feature requires a techpreview job, and it would be better if add testing of different deletion policies (delete and detach). |
|
@sunzhaohua2 because the feature is currently in tech preview and we need to have at least 5 tests to promote to ga. |
|
/cc @jinyunma |
For long term, we should use the unified test suite in cluster-api-actuator-pkg to cover both MAPI and CAPI. Given the framework is not ready, it looks fine to me to place the mapi e2e here. After the framework is done, we can migrate the tests to cluster-api-actuator-pkg. |
|
https://issues.redhat.com/browse/SPLAT-2352
Thanks, got it. I was just testing these on day2 and don't need a tech preview cluster. These tests looks good to me. |
@sunzhaohua2 |
This commit adds e2e tests for the azure data disk feature gate. Assisted with Claude
0deeb5f to
3c65862
Compare
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commit adds e2e tests for the azure
data disk feature gate.
Assisted with Claude