Skip to content

chore: remove .claude submodule and investigations tool references#12

Merged
Umaaz merged 1 commit intomainfrom
chore/remove-claude-submodule
Mar 3, 2026
Merged

chore: remove .claude submodule and investigations tool references#12
Umaaz merged 1 commit intomainfrom
chore/remove-claude-submodule

Conversation

@Umaaz
Copy link
Member

@Umaaz Umaaz commented Mar 3, 2026

Overview

This merge request removes the .claude git submodule to resolve cloning issues for public users. The submodule pointed to a private repository, causing git clone to fail for anyone without access. This change ensures a smoother onboarding experience for new contributors by decoupling the main repository from private dependencies.

Technical Details

  • Submodule Removal:

    • The .claude submodule and the corresponding .gitmodules file have been deleted.
    • The .gitignore file has been updated to include .claude/, allowing developers with access to optionally clone the private repository locally without affecting the main project.
  • Documentation and Configuration Updates:

    • README.md: The row referencing "investigations tools" has been removed.
    • CLAUDE.md & CONTRIBUTING.md: All references to the submodule have been removed and instructions updated to reflect the new setup process.
    • cspell.json: The dictionary has been updated to remove words associated with the submodule.

Review Summary

  • Status: Approved.
  • Test Plan:
    • Verified that git clone completes successfully for users without access to the private opentrace/.claude repository.
    • Confirmed that the local development environment (make dev) and plugin installation processes remain fully functional.

Impact Assessment

  • Security: No security impact. This change modifies repository structure and does not affect application logic or data handling.
  • Performance: No impact on runtime performance. Improves the developer experience by speeding up the initial git clone process.
  • Maintainability: Positive. Simplifies the repository structure and lowers the barrier to entry for new contributors, making the project easier to set up and maintain.

Attached by run cb51c8a7-408b-46bd-931a-9ccee4743f27

The .claude submodule points to a private repo which breaks public clones.
Removed it from git tracking and added .claude/ to .gitignore so OpenTrace
developers can optionally clone it locally. Also removed the investigations
tools row from the README since those tools are no longer exposed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@opentrace opentrace bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@opentrace
Copy link

opentrace bot commented Mar 3, 2026

This is a beneficial maintenance change that improves the experience for public contributors. Removing the private submodule prevents git clone failures for users without access, and the related documentation and .gitignore updates are appropriate. The change is low-risk and improves the overall repository structure.


Attached by run cb51c8a7-408b-46bd-931a-9ccee4743f27

@Umaaz Umaaz enabled auto-merge (squash) March 3, 2026 11:25
@Umaaz Umaaz added the review label Mar 3, 2026
@Umaaz Umaaz merged commit 0826662 into main Mar 3, 2026
1 check passed
@Umaaz Umaaz deleted the chore/remove-claude-submodule branch March 3, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants