chore(msrv): stablize 'let' statements#149
Conversation
|
firing off a release to address #139 would also be nice |
edition 2024 existed in rust versions previous to 1.88, but 'let' chaining syntax had not yet settled down. used <https://foresterre.github.io/cargo-msrv> > This feature was stabilized in 1.88.0 but on edition 2024 only. c.f. rust-lang/rust#53667
billf
force-pushed
the
chore-msrv-stablize-let
branch
from
de3c134 to
85ef8af
Compare
| [workspace.package] | ||
| edition = "2024" | ||
| license = "MIT" | ||
| rust-version = "1.88.0" |
There was a problem hiding this comment.
I don't know that I want to accept the overhead of having to keep this value up to date. Is it worth the hassle?
There was a problem hiding this comment.
the benefit is "fail-faster".
when built using a version prior to 1.88, the use(1 2) of let chaining will cause compilation to fail.
alternatives:
README.mdmodification to say "anything but rust stable unsupported", "anything but building from nix unstable"rust-toolchain.toml(same issue of overhead)- unwinding let chains (ugly. plus, maintainer must remember not to merge PRs that use them)
- modiyfing the github workflow to build using a non-stable version (no good reason to do this)
in the time since this PR was submitted, the required version has gone from "most recent stable" to "a few revisions behind". over time, directionally, fewer users are now impacted...
There was a problem hiding this comment.
I appreciate the effort, I do. But I don't see why do anything at all about this. We have a Nix powered dev shell. And even if some contributor does not use that, they won't take long figuring out that their toolchain version does not support some language feature that is ins use 🤷.
In related news, I have forked this https://github.com/molybdenumsoftware/statix.
2 participants
edition 2024 existed in rust versions previous to 1.88, but
'let' chaining syntax had not yet settled down.
used https://foresterre.github.io/cargo-msrv
c.f. rust-lang/rust#53667