Skip to content

chore(msrv): stablize 'let' statements #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(msrv): stablize 'let' statements #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
764d7e2
chore(msrv): stablize 'let' statements
billf Oct 22, 2025
85ef8af
chore(version): back to pre-release
billf Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ members = ["bin", "lib", "macros", "vfs"]
[workspace.package]
edition = "2024"
license = "MIT"
rust-version = "1.88.0"
Copy link
Copy Markdown
Collaborator

@mightyiam mightyiam Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that I want to accept the overhead of having to keep this value up to date. Is it worth the hassle?

Copy link
Copy Markdown
Author

@billf billf Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the benefit is "fail-faster".

when built using a version prior to 1.88, the use(1 2) of let chaining will cause compilation to fail.

alternatives:

  • README.md modification to say "anything but rust stable unsupported", "anything but building from nix unstable"
  • rust-toolchain.toml(same issue of overhead)
  • unwinding let chains (ugly. plus, maintainer must remember not to merge PRs that use them)
  • modiyfing the github workflow to build using a non-stable version (no good reason to do this)

in the time since this PR was submitted, the required version has gone from "most recent stable" to "a few revisions behind". over time, directionally, fewer users are now impacted...

Copy link
Copy Markdown
Collaborator

@mightyiam mightyiam Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort, I do. But I don't see why do anything at all about this. We have a Nix powered dev shell. And even if some contributor does not use that, they won't take long figuring out that their toolchain version does not support some language feature that is ins use 🤷.

In related news, I have forked this https://github.com/molybdenumsoftware/statix.


[workspace.dependencies]
anyhow = "1.0.100"
Expand Down
3 changes: 2 additions & 1 deletion bin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ authors = ["Akshay <nerdy@peppe.rs>"]
description = "Lints and suggestions for the Nix programming language"
edition.workspace = true
license.workspace = true
rust-version.workspace = true
name = "statix"
version = "0.5.8"
version = "0.5.9-pre"

[lib]
name = "statix"
Expand Down