Fix Lets encrypt update certificate for unicode aliases #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosfriascf
approved these changes
Sep 17, 2019
|
Added to carlosfriascf@2347364 |
Обновление из основного репозитория весты от 30 января 2020 г
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Исправил проблему обновления сертификатов для доменов, у которых в алиасах используются юникод имена.
Получалось, что в web.conf юзера переменная $ALIAS содержала домен в юникоде. Например, www.мой-сайт.рф
А в сертификате этот алиас был в punnicode www.xn----8sbzclmxk.xn--p1ai
В итоге получали ошибку "domain alias $alias doesn't exist"
В проверку добавил в качестве условия "или" вариант с юникод кодировкой домена.
Так работать должно в обоих вариантах: и если юзер указал в алиасе юникод домен, и если вставил туда сразу punnicode.