Skip to content

Fix Lets encrypt update certificate for unicode aliases #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akunich wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Lets encrypt update certificate for unicode aliases #1927

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36a4e93
Fix Lets encrypt update certificate for unicode aliases
akunich Aug 22, 2019
e917016
Merge pull request #1 from serghey-rodin/master
akunich Jan 30, 2020
10db786
Merge pull request #2 from serghey-rodin/master
akunich Sep 10, 2020
8397943
Fix: Update dns cluster before Requesting ACME validation to wildcard…
akunich Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/v-add-letsencrypt-domain
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ get_domain_values 'web'
# check if alias is the letsencrypt wildcard domain, if not, make the normal checks
if [[ "$aliases" != "*.$domain" ]]; then
for alias in $(echo "$aliases" |tr ',' '\n' |sort -u); do
check_alias="$(echo $ALIAS |tr ',' '\n' |grep ^$alias$)"
alias_unicode=`idn -t --quiet -u $alias`
check_alias="$(echo $ALIAS |tr ',' '\n' |egrep ^$alias\|$alias_unicode$)"
if [ -z "$check_alias" ]; then
check_result $E_NOTEXIST "domain alias $alias doesn't exist"
fi
Expand Down Expand Up @@ -155,6 +156,7 @@ for auth in $authz; do
$BIN/v-delete-dns-record $user $domain $old_record
done
$BIN/v-add-dns-record $user $domain "_acme-challenge" "TXT" $record
$BIN/v-update-sys-queue dns-cluster
check_result $? "DNS _acme-challenge record wasn't created"
else
if [ "$WEB_SYSTEM" = 'nginx' ] || [ ! -z "$PROXY_SYSTEM" ]; then
Expand Down