[2/2] migrate to Dropshot API manager #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
26 tasks
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.22-migrate-to-dropshot-api-manager
to
main
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Nieuwejaar
reviewed
Oct 7, 2025
| #[structopt(name = "lldpd", about = "Oxide LLDP daemon")] | ||
| enum Args { | ||
| /// Run the LLDPD API server. | ||
| Run(Opt), |
There was a problem hiding this comment.
If there is only a single subcommand, we can probably just take it out entirely.
There was a problem hiding this comment.
Same comment as oxidecomputer/dendrite#141 (comment).
Nieuwejaar
approved these changes
Oct 7, 2025
sunshowers
deleted the
sunshowers/spr/22-migrate-to-dropshot-api-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of oxidecomputer/omicron#8922.
The manager can be run with
cargo xtask openapi, e.g.cargo xtask openapi generate. There wasn't a test which ensured thatlldpd.jsonwas up-to-date, but now there is.Depends on: