added publisher for analyzed points #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikishor
requested changes
Aug 27, 2025
Comment on lines
120
to
123
| # timer to update items in the menu for payload selection | ||
| self.timer_update_payload_selection = self.create_timer(0.5, self.update_payload_selection) | ||
| # timer to publish all analyzed points in the workspace area | ||
| self.timer_publish_analyzed_points = self.create_timer(2, self.publish_analyzed_points) |
There was a problem hiding this comment.
why are you publishing with a timer?
I didn't notice the previous one earlier
There was a problem hiding this comment.
in this way I reduce the time comsuming in that function, or do you mean that it is possible to publish it once and then stop to publish it because it is the same for all time ?
There was a problem hiding this comment.
Check "transient local” here Quality of Service settings — ROS 2 Documentation: Rolling documentation https://share.google/2BqvINadfaCiZ6Qrl
It is similar to the one you are using to subscribe to a robot_description
There was a problem hiding this comment.
Ok, so in that way I will publish once and it will not require multiple publishing
saikishor
requested changes
Sep 1, 2025
dynamic_payload_analysis_ros/dynamic_payload_analysis_ros/rviz_visualization_menu.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added publisher for analyzed points