Conversation
…e audit Flips the Phase 1 manual-stage hook to fire on regular commits and adds a CI lane scoped to the same ASYNC ruleset, both as soft-fail (``--exit-zero`` for the hook, ``continue-on-error: true`` for CI). After Phase 1's per-file-ignore on ``src/api/service_launcher.py`` (orchestration helper, not a route handler), cascor has **zero visible violations** post-Phase-2. The CI lane and pre-commit hook will catch any new violations introduced by future code changes. Phase 4 will drop ``--exit-zero`` (pre-commit) and ``continue-on-error: true`` (CI) so future violations block. Second of four Phase 2 PRs (data → cascor → canopy → worker). Plan: juniper-ml notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md §4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
pcalnon
added a commit
that referenced
this pull request
May 7, 2026
Drop the soft-fail flags so any new ASYNC* violation hard-fails: - ``.github/workflows/ci.yml``: remove ``continue-on-error: true`` from the ``async-route-audit`` job. Rename to "Async-route audit (BUG-JD-10 class)" (no more "soft-fail" suffix). The ruff command already lacks ``--exit-zero`` (cascor's Phase 2 PR #232 was tightened in fb1b5d4 before this PR existed). - ``.pre-commit-config.yaml``: remove ``--exit-zero`` from the ``ruff-async-audit`` hook so violations block commits. Repo has zero visible violations: the only flagged file (``src/api/service_launcher.py``, orchestration helper) carries a per-file-ignore in pyproject.toml [tool.ruff.lint.per-file-ignores]. Verified ``ruff check --select ASYNC src/`` exits clean. Second of four Phase 4 PRs (data → cascor → canopy → worker). Refs: notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md §4 (in juniper-ml) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 enable for juniper-cascor. Second of four Phase 2 PRs.
Same shape as the data PR (data #94):
Effect
After the Phase 1 per-file-ignore on `src/api/service_launcher.py`
(orchestration helper), cascor has zero visible violations
post-Phase-2. The CI lane and pre-commit hook will catch any new
violations introduced by future code changes.
Test plan
runs and passes — hook now fires on regular commits.
annotation rendering.
🤖 Generated with Claude Code