Skip to content

fix: use pp-base-url input for review URLs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodchalski merged 1 commit into from
Mar 13, 2026
Merged

fix: use pp-base-url input for review URLs #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Open a PR to `main`. Deploy Gate always creates/verifies a PP request and posts

A human must approve before merge.

👉 APPROVE HERE: https://app.permissionprotocol.com/review/dr_abc123
👉 APPROVE HERE: https://app.permissionprotocol.com/pp/deploy-requests/dr_abc123

After approval, re-run this workflow.
═══════════════════════════════════════════════════════════
Expand All @@ -107,13 +107,13 @@ After approval, re-run this workflow.
PR comment (auto-approved / verified):
```markdown
✅ **Permission Protocol:** Approved
[View receipt →](https://app.permissionprotocol.com/review/{requestId})
[View receipt →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId})
```

PR comment (approval required):
```markdown
⏳ **Permission Protocol:** Approval required
[Review & approve →](https://app.permissionprotocol.com/review/{requestId})
[Review & approve →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId})
```

---
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,13 @@ Use this when you want custom scope values and auto-request creation in one work
Auto-approved / verified:
```markdown
✅ **Permission Protocol:** Approved
[View receipt →](https://app.permissionprotocol.com/review/{requestId})
[View receipt →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId})
```

Approval required:
```markdown
⏳ **Permission Protocol:** Approval required
[Review & approve →](https://app.permissionprotocol.com/review/{requestId})
[Review & approve →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId})
```

---
Expand Down
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ runs:
DIAG_KEY_STATUS=$(echo "$HTTP_BODY" | jq -r '.diagnostics.keyStatus // .result.diagnostics.keyStatus // empty' 2>/dev/null || echo "")

if [ -n "$REQUEST_ID" ]; then
REVIEW_URL="https://permissionprotocol.com/review/${REQUEST_ID}"
REVIEW_URL="${PP_BASE_URL}/pp/deploy-requests/${REQUEST_ID}"
else
REVIEW_URL="$APPROVAL_URL"
fi
Expand Down Expand Up @@ -329,7 +329,7 @@ runs:
echo " ${REVIEW_URL}"
echo ""
else
echo " 👉 https://permissionprotocol.com/review"
echo " 👉 ${PP_BASE_URL}/pp/deploy-requests"
echo ""
fi
echo "═══════════════════════════════════════════════════════════"
Expand Down
Loading