fix: use pp-base-url input for review URLs#20
Merged
rodchalski merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
The action was hardcoding 'permissionprotocol.com/review/' for the approval URL, which doesn't match the actual app route (/pp/deploy-requests/). Now uses the PP_BASE_URL env (from pp-base-url input, defaults to app.permissionprotocol.com) and the correct path. Also fixes docs (INSTALL.md, README.md) with correct URL paths.
|
✅ Permission Protocol: Approved |
Collaborator
Author
✅ Authorized by Permission ProtocolSummary: This change updates the deployment workflow to use a configurable base URL and corrects the routing path for review requests, ensuring users are directed to the correct location. It should go live...
🔒 Cryptographically signed · Verified by Permission Protocol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses PP_BASE_URL input instead of hardcoded permissionprotocol.com. Fixes wrong path /review/ → /pp/deploy-requests/.