Skip to content

Reduce code bloat in arginfo by using specialised string releases #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce code bloat in arginfo by using specialised string releases #20016

wants to merge 1 commit into from
+414 −414

Conversation

nielsdos
Copy link
Member

Comparing this patch to master (c7da728), with a plain configure command without any options:

   text	   data	    bss	    dec	    hex	filename
20683738	1592400	 137712	22413850	156021a	sapi/cli/php
20688522	1592400	 137712	22418634	15614ca	sapi/cli/php_old

We see a minor reduction of 0.023% in code size.

@nielsdos
Reduce code bloat in arginfo by using specialised string releases
85acacf 
Comparing this patch to master (c7da728),
with a plain configure command without any options:

```
   text	   data	    bss	    dec	    hex	filename
20683738	1592400	 137712	22413850	156021a	sapi/cli/php
20688522	1592400	 137712	22418634	15614ca	sapi/cli/php_old
```

We see a minor reduction of 0.023% in code size.
@nielsdos nielsdos marked this pull request as ready for review September 30, 2025 16:03
@TimWolla TimWolla removed their request for review October 1, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@kocsismate kocsismate kocsismate approved these changes

@Girgias Girgias Girgias approved these changes

@zeriyoshi zeriyoshi zeriyoshi approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
ABI break Category: Build System Category: Engine Extension: bcmath Extension: curl Extension: date Extension: dom Extension: intl Extension: libxml Extension: mysqli Extension: pdo (core) Extension: random Extension: snmp Extension: soap Extension: spl Extension: standard Extension: tidy Extension: tokenizer Extension: uri Extension: xmlreader Extension: xsl Extension: zend_test Extension: zip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nielsdos @devnexen @kocsismate @Girgias @zeriyoshi