Skip to content

Reduce code bloat in arginfo by using specialised string releases #20016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
+3,796 −3,796
Merged

Reduce code bloat in arginfo by using specialised string releases #20016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85acacf
Reduce code bloat in arginfo by using specialised string releases
nielsdos Sep 30, 2025
696bb59
Also use true for the other initialization line
nielsdos Oct 2, 2025
081e376
Also use specialized code for consts
nielsdos Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions Zend/zend_attributes_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Zend/zend_builtin_functions_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions build/gen_stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,7 +2801,7 @@ private function getClassConstDeclaration(EvaluatedValue $value, array $allConst

$code = "\n" . $zvalCode;

$code .= "\tzend_string *const_{$constName}_name = zend_string_init_interned(\"$constName\", sizeof(\"$constName\") - 1, 1);\n";
$code .= "\tzend_string *const_{$constName}_name = zend_string_init_interned(\"$constName\", sizeof(\"$constName\") - 1, true);\n";
$nameCode = "const_{$constName}_name";

if ($this->exposedDocComment) {
Expand Down Expand Up @@ -2855,7 +2855,7 @@ private function getClassConstDeclaration(EvaluatedValue $value, array $allConst
$code .= "#endif\n";
}

$code .= "\tzend_string_release(const_{$constName}_name);\n";
$code .= "\tzend_string_release_ex(const_{$constName}_name, true);\n";

return $code;
}
Expand Down Expand Up @@ -3058,13 +3058,13 @@ public static function getString(
// Generally strings will not be known
$initFn = $interned ? 'zend_string_init_interned' : 'zend_string_init';
$result = [
"\tzend_string *$varName = $initFn(\"$content\", sizeof(\"$content\") - 1, 1);\n",
"\tzend_string *$varName = $initFn(\"$content\", sizeof(\"$content\") - 1, true);\n",
$varName,
"\tzend_string_release($varName);\n"
"\tzend_string_release_ex($varName, true);\n"
];
// For attribute values that are not freed
if ($varName === '') {
$result[0] = "$initFn(\"$content\", sizeof(\"$content\") - 1, 1);\n";
$result[0] = "$initFn(\"$content\", sizeof(\"$content\") - 1, true);\n";
}
// If not set, use the current latest version
$allVersions = ALL_PHP_VERSION_IDS;
Expand Down
4 changes: 2 additions & 2 deletions ext/bcmath/bcmath_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ext/curl/curl_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading