Use nullable return type for TypePart::getTypeNullable()#64
Open
bnf wants to merge 2 commits intophpowermove:masterfrom
Open
Use nullable return type for TypePart::getTypeNullable()#64bnf wants to merge 2 commits intophpowermove:masterfrom
bnf wants to merge 2 commits intophpowermove:masterfrom
Conversation
…nition …when generateNullableTypes is enabled
This is to prevent a fatal error when setNullable has not been called explicitly, when generateNullableTypes is enabled. Error was: PHP Fatal error: Uncaught TypeError: Return value of gossi\codegen\model\PhpParameter::getNullable() must be of the type bool, null returned in […]/vendor/gossi/php-code-generator/src/model/parts/TypePart.php:75
bnf
changed the title
Author
|
Hi, I forgot to add a test for the initial pull request. Sorry for that – I've just added one. Looking forward to a 0.6 release containing this fix :) |
bnf
added a commit
to qbus-agentur/openimmo
that referenced
this pull request
Aug 23, 2019
…ator to fix api (re)generation The recent nullable return type changes rely on a (currently open) pull request for gossi/php-code-generator: phpowermove/php-code-generator#64
This was referenced Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…when setNullable has not been called explicitly.
Error was: