Keybindings respect permissions

[MSchinwaldEl]

Changes in this pull request

• Checks permissions in key bindings (Resolves [Keybindings] respect permissions #2357)
• Show actual SEO keybindings in SEO accordion in keybindings overview (SEARCH_FIELDS were shown twice)

[markus-moser]

@MSchinwaldEl
In general it LGTM, but there are at least the following lines missing:

studio-ui-bundle/assets/js/src/core/modules/element/editor/shared-tab-manager/tabs-container.tsx

Lines 60 to 62 in 5e0fcef

	useHandleKeyBindings(() => { if (element != null) rename(element.id, getElementKey(element as unknown as Element, elementType)) }, 'rename')
	useHandleKeyBindings(() => { if (element != null) publishNode(element as unknown as Element) }, 'publish')
	useHandleKeyBindings(() => { if (element != null && !isNull(elementType) && elementType !== 'asset') unpublishTreeNode(element as unknown as DataObject | Document) }, 'unpublish')

[MSchinwaldEl]

@MSchinwaldEl In general it LGTM, but there are at least the following lines missing:

studio-ui-bundle/assets/js/src/core/modules/element/editor/shared-tab-manager/tabs-container.tsx

Lines 60 to 62 in 5e0fcef

	useHandleKeyBindings(() => { if (element != null) rename(element.id, getElementKey(element as unknown as Element, elementType)) }, 'rename')
	useHandleKeyBindings(() => { if (element != null) publishNode(element as unknown as Element) }, 'publish')
	useHandleKeyBindings(() => { if (element != null && !isNull(elementType) && elementType !== 'asset') unpublishTreeNode(element as unknown as DataObject | Document) }, 'unpublish')

I didn't implement the permission checks for these because, if I understand correctly, these keybindings can only be used in the element editor, which users can only open if they already have the appropriate permissions.
However, I can add the check. Which permissions would be the correct ones here? The element type (Documents/Objects/Assets)?

[markus-moser]

@MSchinwaldEl You will find them in the related actions:

studio-ui-bundle/assets/js/src/core/modules/element/actions/publish/use-publish.tsx

Line 37 in a2fe4c2

!isTreeActionAllowed(TreePermission.Publish) ||

studio-ui-bundle/assets/js/src/core/modules/element/actions/unpublish/use-unpublish.tsx

Line 41 in a2fe4c2

return !checkElementPermission(node.permissions, 'unpublish') ||

studio-ui-bundle/assets/js/src/core/modules/element/actions/rename/use-rename.tsx

Line 82 in a2fe4c2

hidden: !checkElementPermission(node.permissions, 'rename') || node.isLocked,

but please use the enum for all locations, thanks

[MSchinwaldEl]

@MSchinwaldEl You will find them in the related actions:

studio-ui-bundle/assets/js/src/core/modules/element/actions/publish/use-publish.tsx

Line 37 in a2fe4c2

!isTreeActionAllowed(TreePermission.Publish) ||

studio-ui-bundle/assets/js/src/core/modules/element/actions/unpublish/use-unpublish.tsx

Line 41 in a2fe4c2

return !checkElementPermission(node.permissions, 'unpublish') ||

studio-ui-bundle/assets/js/src/core/modules/element/actions/rename/use-rename.tsx

Line 82 in a2fe4c2

hidden: !checkElementPermission(node.permissions, 'rename') || node.isLocked,

but please use the enum for all locations, thanks

I added the missing permissions. As discussed in our call, there are no enums for elementPermissions.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud