Bugfix stable 3 5 0 100 fix captcha on login#130
Open
jonasraoni wants to merge 3 commits intopkp:stable-3_5_0from
Open
Bugfix stable 3 5 0 100 fix captcha on login#130jonasraoni wants to merge 3 commits intopkp:stable-3_5_0from
jonasraoni wants to merge 3 commits intopkp:stable-3_5_0from
Conversation
jonasraoni
force-pushed
the
bugfix-stable-3_5_0-100-fix-captcha-on-login
branch
from
bf63eed to
e5848c8
Compare
| if ($isCaptchaEnabled) { | ||
| $templateMgr->addJavaScript( | ||
| 'recaptcha', | ||
| 'https://www.recaptcha.net/recaptcha/api.js?hl=' . substr(Locale::getLocale(), 0, 2) |
Member
There was a problem hiding this comment.
Should substr still be used here? I see in PKPTemplateManager we no longer use it as of 3.5: https://github.com/pkp/pkp-lib/blob/ff423896b6459b98b4ab96444175c751f7dd821c/classes/template/PKPTemplateManager.php#L264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.