fix: unset shader field in material migration instead of setting it #1710
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration comment says 'remove shader' but the code was setting it to 'blinn', which causes a C3 validation error since the shader field is not defined in the material data schema. Changed to unset() to be consistent with how fresnelModel is handled. Fixes #1709
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the material migration logic so that deprecated shader data is actually removed instead of being set to an unsupported value, resolving validation errors in the collab-server.
Changes:
- Replace
asset.set('data.shader', 'blinn')withasset.unset('data.shader')in the material migration. - Update the migration log message to state that
data.shaderhas been removed rather than switched.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slimbuck
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
shaderfield instead of setting it to'blinn'Problem
The migration code comment says "remove shader" but it was actually setting the field to
'blinn'. This caused a C3 validation error in the collab-server because theshaderfield is not defined in the material data schema.Solution
Changed
asset.set('data.shader', 'blinn')toasset.unset('data.shader')to be consistent with howfresnelModelis handled in the same migration.Fixes #1709