remove spinstreak arg for event

[yogurtandjam]

What's new in this PR?

In bullet point format, please describe what's new in this PR.

Why?

What problem does this solve?
Why is this important?
What's the context?

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• Spin.sol: Removed currentStreak parameter from the SpinCompleted event for simplicity.

---

🔗 Commit Hash: be314fd

[Copilot]

Pull request overview

This PR removes the currentStreak parameter from the SpinCompleted event to simplify the event signature. The change reduces event data emissions while the streak information remains accessible through the contract's state.

Changes:

• Removed currentStreak parameter from the SpinCompleted event declaration
• Updated event emission to exclude the streak value

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Removing the currentStreak parameter from the SpinCompleted event is a breaking change that will affect any off-chain systems (indexers, analytics dashboards, frontend applications) currently listening to this event. While the currentStreak value is still computed and stored in userDataStorage.streakCount (line 253), it's no longer emitted in the event. Consider whether off-chain consumers need this data or if they can retrieve it through other means (e.g., by querying the userData mapping).

[octane-security-app]

Overview

Vulnerabilities found:	1
Severity breakdown:	1 Low

Warnings found:	4

Detailed findings

plume/src/spin/Spin.sol

• Reverting native-asset payout in Spin.handleRandomness causes per-user spins to remain pending (self-DoS). See more

Warnings

plume/src/spin/Spin.sol

• Reward logic depends on callback-time block.timestamp in Spin.sol causes oracle to bias jackpot outcomes. See more
• Unrestricted admin withdrawals and no payout reserve in Spin.handleRandomness cause user fee loss and denied payouts. See more
• Mutable admin-controlled reward parameters at randomness callback in Spin.sol cause loss of user spin fees via retroactive outcome changes/cancellation. See more
• Unprotected initializer (missing _disableInitializers()) in Spin.sol implementation causes off-chain tooling confusion. See more

---

🔗 Commit Hash: be314fd
🛡️ Octane Dashboard: All vulnerabilities