Skip to content

remove spinstreak arg for event #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogurtandjam merged 1 commit into from
Jan 13, 2026
Merged

remove spinstreak arg for event #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions plume/src/spin/Spin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ contract Spin is

// Events
event SpinRequested(uint256 indexed nonce, address indexed user);
event SpinCompleted(
address indexed walletAddress, string rewardCategory, uint256 rewardAmount, uint256 currentStreak
);
event SpinCompleted(address indexed walletAddress, string rewardCategory, uint256 rewardAmount);
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the currentStreak parameter from the SpinCompleted event is a breaking change that will affect any off-chain systems (indexers, analytics dashboards, frontend applications) currently listening to this event. While the currentStreak value is still computed and stored in userDataStorage.streakCount (line 253), it's no longer emitted in the event. Consider whether off-chain consumers need this data or if they can retrieve it through other means (e.g., by querying the userData mapping).

Copilot uses AI. Check for mistakes.
event RaffleTicketsSpent(address indexed walletAddress, uint256 ticketsUsed, uint256 remainingTickets);
event NotEnoughStreak(string message);
event JackpotAlreadyClaimed(string message);
Expand Down Expand Up @@ -263,7 +261,7 @@ contract Spin is
_safeTransferPlume(user, rewardAmount * 1 ether);
}

emit SpinCompleted(user, rewardCategory, rewardAmount, currentSpinStreak);
emit SpinCompleted(user, rewardCategory, rewardAmount);
}

/**
Expand Down