Open
Conversation
The `ffidisp` module is described as "the legacy design used up to 0.6.x. It is not recommended for new development." This also uses `SyncConnection` in the server, rather than `Connection`, so it can be shared between threads.
This defines a new dbus interface `com.system76.PowerDaemon.Keyboard`. This wraps the sysfs API without requiring root access. This is handled in a seperate thread that monitors brightness and color changes with inotify. The API might later be extended to support things like setting keymaps.
Member
Author
|
This doesn't quite expose all the functionality needed for the design in pop-os/gnome-control-center#102. That will also require the EC to persist settings, handle the color change key (instead of the kernel driver handling it), and support changing the list of colors that are switched better. And of course the Keyboard Configurator will need a few more things, mainly support for changing the keymap. |
leviport
approved these changes
Sep 11, 2020
Member
leviport
left a comment
leviport
left a comment
There was a problem hiding this comment.
I can't figure out how to test the keyboard-backlight app, but this PR causes no regressions, so I'm satisfied with it.
Member
Author
|
@jackpot51 Thoughts on this? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keyboard-backlightrepository has code using this. The API can be used with the code there to add a brightness/color setting in Gnome Control Center, and can later be used for the Keyboard Configurator.This is rather more complicated than my previous attempt at an API for this (#177), but the general design is hopefully fairly robust and can be extended for more functionality we may need.