Support for v1 Server Reflection #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

appurva21 merged 8 commits into master from feat/support-for-v1-server-reflection

Oct 30, 2025

Collaborator

deve-sh commented Oct 29, 2025 •

edited

Loading

What this PR does

Adds support for multiple versions of the gRPC server reflection API (In parallel, sorted by priority if multiple versions are supported on the same server).
Adds separate compilation for proto files needed for reflection checks.
Updates structure of repository to reflect support for multiple versions.

Stacked PRs

Add tests for v1 and v1alpha + Backwards compatibility checks: Added in Add tests for V1 and V1 Alpha Server Reflection #6

deve-sh added 2 commits

October 29, 2025 15:16


          Initial: Clear out compilation commands for multiple reflection proto…

2c79413

…cols


          Implement detection of available protocol and creation of gRPC client

004395c

deve-sh commented

View reviewed changes

static/grpc/reflection/v1/reflection.proto

Collaborator Author

deve-sh Oct 29, 2025

Picked up from a public v1 reflection source

deve-sh commented

View reviewed changes

src/reflection_providers/v1alpha/reflection_pb.js

Collaborator Author

deve-sh Oct 29, 2025

Autogenerted

deve-sh commented

View reviewed changes

src/reflection_providers/v1alpha/reflection_pb.d.ts

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated

deve-sh commented

View reviewed changes

src/reflection_providers/v1alpha/reflection_grpc_pb.js

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/reflection_providers/v1alpha/reflection_grpc_pb.d.ts

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/reflection_providers/v1/reflection_pb.js

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/reflection_providers/v1/reflection_pb.d.ts

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/reflection_providers/v1/reflection_grpc_pb.d.ts

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/reflection_providers/v1/reflection_grpc_pb.js

Collaborator Author

deve-sh Oct 29, 2025

Autogenerated file

deve-sh commented

View reviewed changes

src/client.ts

Comment on lines +176 to +178

    
                    if (this.reflectionResponseCache) {

                      return dataCallback(this.reflectionResponseCache);

                    }

Collaborator Author

deve-sh Oct 29, 2025

This should always be hit after invoking initializeReflectionClient.

deve-sh commented

View reviewed changes

src/client.ts Outdated Show resolved Hide resolved

deve-sh added 5 commits

October 29, 2025 22:34


          Support parallel resolution of supported reflection protocol check

ad0cc1c


          Rename protocol to version

dd268d7


          Ensure error is thrown if no compatible reflection API is found

e7a753e


          Refine dynamic imports

173c6d9


          Update client compatible version property

5440b3d

deve-sh changed the title ~~[WIP] Support for v1 Server Reflection~~ Support for v1 Server Reflection


          fix: Import issues when used by consumers

7a70aa3

appurva21 approved these changes

View reviewed changes

appurva21 merged commit aa0afd5 into master

4 checks passed

deve-sh deleted the feat/support-for-v1-server-reflection branch

October 30, 2025 15:51

deve-sh mentioned this pull request

Add support for server reflection using v1 protocol #3

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet