Remove undefined ASAN_RUNTIME_DEP from runtime deps #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on ASAN_RUNTIME_DEP removal in mimalloc support PR
Remove undefined ASAN_RUNTIME_DEP from runtime deps
Dec 4, 2025
Member
|
@copilot ASAN_RUNTIME_DEP is already removed and pushed to feature/mimalloc branch. You mentioned about adding $ to make the generator expression clearer in PR #6 "$<IF:$AND:$BOOL:${USE_MIMALLOC},$CONFIG:Release,${MIMALLOC_INSTALL_DIR}/bin/mimalloc.dll;${MIMALLOC_INSTALL_DIR}/bin/mimalloc-redirect.dll,> |
Contributor
Author
I've verified that |
Member
Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
Contributor
Author
asn5d
added a commit
that referenced
this pull request
Dec 4, 2025
* Add optional mimalloc allocator support for Release builds. * Update RoiManager/CMakeLists.txt to check mimalloc target exists before linking. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update PluginManager/CMakeLists.txt to check mimalloc target exists before linking. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update CMakeLists.txt to show message that mimalloc will be linked for Release only. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added link option /INCLUDE:mi_version in cvutil/CMakeLists.txt only for MSVC Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Updated CMakeLists.txt to include platform specific import locations. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix generator expression in ExternalProject_Add for mimalloc (#8) * Initial plan * Replace $<CONFIG> with ${CMAKE_BUILD_TYPE} in ExternalProject_Add Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> * Use hardcoded Release build type for mimalloc ExternalProject Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> * Remove undefined ASAN_RUNTIME_DEP from runtime deps (#9) * Initial plan * Remove undefined ASAN_RUNTIME_DEP from EXTRA_RUNTIME_DEPS Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> * Remove undefined ASAN_RUNTIME_DEP from runtime deps (#10) * Initial plan * Remove undefined ASAN_RUNTIME_DEP from EXTRA_RUNTIME_DEPS expression Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> * Use $<IF> syntax for EXTRA_RUNTIME_DEPS generator expression Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: Seethepalli <7uz@ornl.gov> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #6 regarding undefined
ASAN_RUNTIME_DEPvariable reference in the EXTRA_RUNTIME_DEPS CMake expression.Changes
$<$<CONFIG:Debug>:;${ASAN_RUNTIME_DEP}>from the generator expression since the variable is never defined$<IF>syntax for cleaner generator expressionBefore
-D EXTRA_RUNTIME_DEPS="$<$<AND:$<BOOL:${USE_MIMALLOC}>,$<CONFIG:Release>>:${MIMALLOC_INSTALL_DIR}/bin/mimalloc.dll;${MIMALLOC_INSTALL_DIR}/bin/mimalloc-redirect.dll>$<$<CONFIG:Debug>:;${ASAN_RUNTIME_DEP}>"After
-D EXTRA_RUNTIME_DEPS="$<IF:$<AND:$<BOOL:${USE_MIMALLOC}>,$<CONFIG:Release>>,${MIMALLOC_INSTALL_DIR}/bin/mimalloc.dll;${MIMALLOC_INSTALL_DIR}/bin/mimalloc-redirect.dll,>"💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.