Added optional mimalloc allocator support for Release builds #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds optional mimalloc allocator support for Release builds as an enhancement, along with several important bug fixes and code quality improvements across the codebase.
Key Changes:
- Integration of mimalloc allocator as an optional external dependency for Release builds
- Modernization of CMake build system using interface libraries for compiler flags
- Critical bug fixes in loop boundaries and array access patterns
- Performance improvements through const reference parameter passing
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Adds mimalloc ExternalProject integration, modernizes compiler flags with interface library, moves compiler detection before project() |
| cvutil/CMakeLists.txt | Adds mimalloc linking for Release builds, updates runtime dependency handling with EXTRA_RUNTIME_DEPS support |
| RoiManager/CMakeLists.txt | Adds mimalloc linking for Release builds, comments out legacy build output configuration |
| PluginManager/CMakeLists.txt | Adds mimalloc linking for Release builds, comments out legacy build output configuration |
| CMake/find_runtime_deps.cmake | Adds support for explicitly specified extra runtime dependencies via EXTRA_RUNTIME_DEPS |
| cvutilConfig.cmake.in | Reverts from install(FILES) to file(INSTALL) for runtime dependency installation |
| cvutil/cvutil_matlab_interface.h | Changes string parameter to const reference for find() function |
| cvutil/cvutil_matlab_interface.cpp | Fixes off-by-one errors in loop bounds (5 instances), updates find() signature, initializes Mat val with braces |
| cvutil/cvutil_linesim.h | Changes vector parameter to const reference for doughlas_peucker() |
| cvutil/cvutil_linesim.cpp | Implements const reference parameter with local copy modification pattern |
| cvutil/cvutil_core.h | Changes vector parameter to const reference for doughlas_peucker() |
| cvutil/cvutil_core.cpp | Updates doughlas_peucker() signature, fixes matrix type references in bwthin() boundary padding |
| cvutil/cvutil_bwthin.cpp | Adds bounds checking before array access (12 instances) |
| cvutil/cvutil_bwskel.cpp | Corrects row offset from 2 to 3 for rectify_components(), splits long conditionals |
| cvutil/cvutil_bwdist.cpp | Fixes off-by-one error in loop bound |
| .gitignore | Adds [Ii]nstall/ directory to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asn5d
force-pushed
the
feature/mimalloc
branch
from
6675db5 to
e6c51fc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
…re linking. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…efore linking. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
…r Release only. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…or MSVC Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
* Initial plan
* Replace $<CONFIG> with ${CMAKE_BUILD_TYPE} in ExternalProject_Add
Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
* Use hardcoded Release build type for mimalloc ExternalProject
Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
* Initial plan * Remove undefined ASAN_RUNTIME_DEP from EXTRA_RUNTIME_DEPS Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
* Initial plan * Remove undefined ASAN_RUNTIME_DEP from EXTRA_RUNTIME_DEPS expression Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> * Use $<IF> syntax for EXTRA_RUNTIME_DEPS generator expression Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asn5d <16312669+asn5d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional enhancement, not the main fix for #2 / #3.