Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

Note: This PR contains no changes because the requested fixes are already present in the base branch feature/mimalloc.

The if(TARGET mimalloc) check has already been added to both PluginManager/CMakeLists.txt and RoiManager/CMakeLists.txt via earlier sub-PRs that were merged into feature/mimalloc.

Verification

All three CMakeLists.txt files now have the consistent pattern:

  • cvutil/CMakeLists.txt (lines 123-133) ✓
  • PluginManager/CMakeLists.txt (lines 63-71) ✓
  • RoiManager/CMakeLists.txt (lines 55-64) ✓
if(USE_MIMALLOC)
    if(TARGET mimalloc)
        target_link_libraries(PluginManager PRIVATE $<$<CONFIG:Release>:mimalloc>)
        # ...
    else()
        message(WARNING "USE_MIMALLOC is ON but mimalloc target not found!")
    endif()
endif()

This PR can be closed as the work is already complete in PR #6's base branch.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Address feedback on optional mimalloc allocator support Add TARGET mimalloc check in PluginManager and RoiManager CMakeLists.txt Dec 4, 2025
Copilot AI requested a review from asn5d December 4, 2025 16:51
@asn5d asn5d marked this pull request as ready for review December 4, 2025 18:55
Copilot stopped work on behalf of asn5d due to an error December 4, 2025 18:57
@asn5d
Copy link
Member

asn5d commented Dec 4, 2025

@copilot I am not seeing the required changes. Can you check?

Copy link
Contributor Author

Copilot AI commented Dec 4, 2025

@copilot I am not seeing the required changes. Can you check?

The if(TARGET mimalloc) check has already been added to both PluginManager/CMakeLists.txt and RoiManager/CMakeLists.txt in the base branch feature/mimalloc (lines 63-71 in both files). This was merged via earlier sub-PRs.

Since the base branch already contains these changes, this PR shows no diff. The fix is complete in PR #6 - all three CMakeLists.txt files now have the consistent pattern:

if(USE_MIMALLOC)
    if(TARGET mimalloc)
        target_link_libraries(...mimalloc>)
        ...
    else()
        message(WARNING "USE_MIMALLOC is ON but mimalloc target not found!")
    endif()
endif()

This PR can be closed as the work is already complete in the base branch.

Copilot AI changed the title Add TARGET mimalloc check in PluginManager and RoiManager CMakeLists.txt [No Changes] TARGET mimalloc check already in base branch Dec 4, 2025
@asn5d asn5d closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants