Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 27, 2025

Addresses feedback on #7081 to remove the renderWithTheme helper function that no longer serves a purpose beyond wrapping HTMLRender.

Changes

  • Removed renderWithTheme helper function definition
  • Replaced all 15 usages with direct HTMLRender calls throughout test file

The helper was originally used to provide theming context but is now redundant after feature flag removal.

// Before
const renderWithTheme = (component: React.ReactElement) => HTMLRender(component)
renderWithTheme(<Breadcrumbs overflow="menu">...</Breadcrumbs>)

// After
HTMLRender(<Breadcrumbs overflow="menu">...</Breadcrumbs>)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

⚠️ No Changeset found

Latest commit: 9ce7af4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: pksjce <417268+pksjce@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on breadcrumbs overflow menu feature flag Remove unused renderWithTheme helper from Breadcrumbs tests Oct 27, 2025
Copilot AI requested a review from pksjce October 27, 2025 06:09
Copilot finished work on behalf of pksjce October 27, 2025 06:09
@pksjce pksjce marked this pull request as ready for review October 27, 2025 11:50
@pksjce pksjce requested a review from a team as a code owner October 27, 2025 11:50
@pksjce pksjce requested a review from jonrohan October 27, 2025 11:50
@pksjce pksjce merged commit 53bdd38 into pk/remove-breadcrumbs-ff-2 Oct 27, 2025
25 of 52 checks passed
@pksjce pksjce deleted the copilot/sub-pr-7081 branch October 27, 2025 11:50
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 27, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants