Skip to content

Conversation

@luca24balboni
Copy link

Fixed sbr_port_rsp_o.gnt of obi_cut module directly connected to ready_o port of spill_register causing protocol violation.

obi_cut

@micprog
Copy link
Member

micprog commented Nov 12, 2025

Checking the spec, this is legal behavior:
Screenshot 2025-11-12 at 16 47 45

@alenad95
Copy link
Member

Hi @micprog, thanks for the feedback! I'm adding myself to the discussion since I'm supervising @luca24balboni.

I would have expected the actual grant being propagated through the CUT. Since the behavior of the grant coming from the CUT is compliant to the OBI protocol, I'm closing the PR.

@alenad95 alenad95 closed this Nov 12, 2025
@micprog
Copy link
Member

micprog commented Nov 12, 2025

Since the goal of the cut module is to cut combinational paths, especially the handshake signals should not be propagated straight through. If you want the behavior in this PR added, it might make sense to add it in case the CombGnt bit in the ObiCfg is set, although this configuration does not enforce this behavior, only permits it (the configuration is discouraged for performance reasons).
Screenshot 2025-11-12 at 18 17 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants