Skip to content

Fix signatures for function pointers passed through __Pyx_IsSameCFunction#213

Merged
agriyakhetarpal merged 4 commits intomainfrom
updates-for-scipy
Jun 30, 2025
Merged

Fix signatures for function pointers passed through __Pyx_IsSameCFunction#213
agriyakhetarpal merged 4 commits intomainfrom
updates-for-scipy

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal commented Jun 29, 2025

Description

The rationale here is that in C code generated by Cython when compiling SciPy, __Pyx_IsSameCFunction usually carries void types for extension modules, but we need to cast to ints instead. As this phenomenon occurs during the code generation steps where the generated files are not addressable via patches or sed commands, we therefore handle it via scipy_fix_cfile() here.

Tip

This PR builds upon the changes made in #168, and it is the second PR in a series of PRs to build newer versions of SciPy; please review that PR first.

PR stack

Please review the following PRs in the order listed below:

Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agriyakhetarpal
Copy link
Copy Markdown
Member Author

Thanks for the review!

@agriyakhetarpal agriyakhetarpal merged commit ee11882 into main Jun 30, 2025
6 checks passed
@agriyakhetarpal agriyakhetarpal deleted the updates-for-scipy branch June 30, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants