Add pyodide-build repository as a submodule#140
Add pyodide-build repository as a submodule#140agriyakhetarpal merged 2 commits intopyodide:mainfrom
pyodide-build repository as a submodule#140Conversation
Package Build ResultsTotal packages built: 28 Package Build Times (click to expand)
Longest build: openssl (2m 29s) |
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! I hope we can stop using pyodide-build submodule someday, both in pyodide/pyodide and here, when pyodide-build is stable enough to handle most of the edge cases. But for now, it looks good to me.
|
I'll review the corresponding PRs too. |
I agree! We've made significant progress in making its various parts extensible and overrideable, so perhaps not much more would be needed to achieve this. |
|
Thank you for the review! |
Description
This PR adds
pyodide-buildas a submodule, just like it is the case in the Pyodide main/runtime repository. This has a few advantages:pyodide-buildto assess breakages for new changes or compatibility with older changespywasmcross.pyto assess changesAs we've pinned our Pyodide build environment in
pyproject.tomlin the repository root, this PR does not introduce any ABI or compilation-specific changes.Note
The note below has been resolved; the submodule points to pyodide/pyodide-build@ee11882 on the
mainbranch now.Tip
The submodule checked in this PR builds upon my branch, which I've submitted as a PR at pyodide/pyodide-build#213. Once merged, I shall update the submodule to point tomain. Please review that PR first. Thank you!PR stack
Please review the following PRs in the order listed below:
-headerpad_max_install_namesand-dead_strip_dylibsforwasm-ldpyodide-build#168__Pyx_IsSameCFunctionpyodide-build#213pyodide-buildrepository as a submodule #140 ➡️ you are here