Replace deprecated pkg_resources with importlib#393
Replace deprecated pkg_resources with importlib#393endrebak merged 2 commits intopyranges:masterfrom
Conversation
|
I will likely have time to have look at your PRs the 14/02. Thanks |
|
It needs to pass first though :) |
|
@endrebak Friendly ping here :) The tests won't run for me without approval from a maintainer: |
|
Thanks! |
Transition to importlib.resources for file traversal and importlib for version.
|
Looks like the tests themselves are broken… |
|
I'll have a quick look. Have you tried the new pyranges btw? https://github.com/pyranges/pyranges_1.x It will soon get a new rust backend |
|
Would you bother updating the CHANGELOG and bump the version also? I'll just run the tests locally and merge squash myself afterwards |
|
If I make changes to your commits I'm not certain you will get credit on github |
|
Will do! I'm excited about pyranges_1.x! Wasn't sure if/when it was launching to replace pyranges :) |
For replacing deprecated pkg_resources
|
Thanks. I started a build wheels and upload packages to pypi workflow here: https://github.com/pyranges/pyranges/actions/runs/13702739555 |

setuptoolsrecently deprecatedpkg_resources, and instead recommendsimportlib(available since Python 3.8).Without this update, tests and packages relying on
pyrangesbreak (in part because setuptools is not declared as a dependency).I think this approach is preferrable over #390, since pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html