Fix importlib error in older python introduced in #393#395
Merged
endrebak merged 1 commit intopyranges:masterfrom Mar 14, 2025
Merged
Fix importlib error in older python introduced in #393#395endrebak merged 1 commit intopyranges:masterfrom
endrebak merged 1 commit intopyranges:masterfrom
Conversation
|
I've also hit this one: sgkit-dev/vcztools#145 |
Collaborator
|
I have started a run to create wheels and so on now for your version. Thanks https://github.com/pyranges/pyranges/actions/runs/13858623862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python 3.11 (and I would assume earlier python too),
metadatais not an attribute ofimportlibso instead ofyou have to explicitely do:
Thus #393 introduces a bug on py<3.13.
Would it be possible to use a python matrix CI github action to prevent this in the future ?
Also if we python <3.8 is still supported then likely needs to have fallback into
importlib-metadataandimportlib-resources.