Skip to content

Fix importlib error in older python introduced in #393#395

Merged
endrebak merged 1 commit intopyranges:masterfrom
maclandrol:fix-regression
Mar 14, 2025
Merged

Fix importlib error in older python introduced in #393#395
endrebak merged 1 commit intopyranges:masterfrom
maclandrol:fix-regression

Conversation

@maclandrol
Copy link
Copy Markdown
Contributor

@maclandrol maclandrol commented Mar 11, 2025

In python 3.11 (and I would assume earlier python too), metadata is not an attribute of importlib so instead of

import importlib
importlib.metadata

you have to explicitely do:

import importlib.metadata
importlib.metadata

Thus #393 introduces a bug on py<3.13.

Would it be possible to use a python matrix CI github action to prevent this in the future ?

Also if we python <3.8 is still supported then likely needs to have fallback into importlib-metadata and importlib-resources.

@jeromekelleher
Copy link
Copy Markdown

I've also hit this one: sgkit-dev/vcztools#145

@endrebak endrebak merged commit c981927 into pyranges:master Mar 14, 2025
4 of 9 checks passed
@endrebak
Copy link
Copy Markdown
Collaborator

I have started a run to create wheels and so on now for your version. Thanks

https://github.com/pyranges/pyranges/actions/runs/13858623862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants