-
-
Notifications
You must be signed in to change notification settings - Fork 10
Introduces Poses table and related endpoints udpates #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 83.91% 83.99% +0.08%
==========================================
Files 39 42 +3
Lines 1212 1318 +106
==========================================
+ Hits 1017 1107 +90
- Misses 195 211 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MateoLostanlen @frgfm happy to get your feedbacks ! |
MateoLostanlen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fe51, thnaks for the PR
few remarks
out need from .crud_pose import * insrc/app/crud/init.py and from .poses import * in src/app/schemas/init.py
|
We miss a route to get all poses associated to a camera |
MateoLostanlen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi please can you update create_detection incleint too ? we need to pass a pose id now
Nice catch, took in account your comment and had introduced pose_id as param. |
just the corresponding test missing and we are good to go ! |
MateoLostanlen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, thanks @fe51

This PR to address #528 which is part of the planned changes to the data model
It introduces the following modifications
What is missing (to be discussed of to handle in another PR)
Happy to discuss it !