[ET-VK][ez] Consolidate tensor metadata calculation + buffer binding code #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SS-JIA merged 1 commit into main from gh/SS-JIA/296/head

Aug 23, 2025

Contributor

SS-JIA commented Aug 22, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D80800085

pytorch-bot bot commented Aug 22, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13594

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Aug 22, 2025

[ET-VK][testing] Add scripts to facilitate operator testiing #13593

Merged

[ET-VK] Introduce BufferMetadata GLSL struct to abstract tensor layout #13595

Merged

[ET-VK][ez] Allow high dimensional tensors (for buffer storage) #13596

Merged

meta-cla bot added the CLA Signed label

SS-JIA mentioned this pull request

[ET-VK] High dim tensor support for view, unsqueeze, squeeze, clone #13597

Merged

github-actions bot commented Aug 22, 2025

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Contributor Author

SS-JIA commented Aug 22, 2025

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This was referenced Aug 22, 2025

[ET-VK][ez] Fix partitioner logic of finding keepdim arg of reduce ops #13598

Merged

[ET-VK][ez] Support grouped convolutions #13599

Merged

[ET-VK][ez] Use XNNPACK's FuseBatchNorm pass #13600

Merged

SS-JIA pushed a commit that referenced this pull request


          [ET-VK][ez] Consolidate tensor metadata calculation + buffer binding …

4dfab3b

…code

Pull Request resolved: #13594

As title, this diff consolidates logic used to calculate flipped and unsqueezed tensor metadata as well as initializing + retrieving buffer bindings for UBOs that contain tensor metadata.


@imported-using-ghimport

Differential Revision: [D80800085](https://our.internmc.facebook.com/intern/diff/D80800085/)
ghstack-source-id: 304941376

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

facebook-github-bot added the fb-exported label

manuelcandales approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

4 similar comments

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80800085

SS-JIA added a commit that referenced this pull request


          [ET-VK][ez] Fix partitioner logic of finding keepdim arg of reduce ops (

6c1f9fa

#13598)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* __->__ #13598

Title says it all. For reduce ops, their signature are not all alike so
some extra legwork needs to be done to identify specific arguments that
need to be checked.

Also included a small update to partitioner logging to improve
debuggability.

Differential Revision:
[D80741737](https://our.internmc.facebook.com/intern/diff/D80741737/)

---------

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

SS-JIA added a commit that referenced this pull request


          [ET-VK][ez] Support grouped convolutions (#13599)

975a4a3

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* #13593
* #13600
* __->__ #13599
* #13598

Title says it all!

Differential Revision:
[D80741734](https://our.internmc.facebook.com/intern/diff/D80741734/)

---------

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

SS-JIA added a commit that referenced this pull request


          [ET-VK][ez] Use XNNPACK's FuseBatchNorm pass (#13600)

bd70337

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* #13593
* __->__ #13600
* #13599
* #13598

As title. Use XNNPACK's FuseBatchNorm pass since it can fuse into linear
layers as well.

Differential Revision:
[D80741735](https://our.internmc.facebook.com/intern/diff/D80741735/)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

SS-JIA added a commit that referenced this pull request


          [ET-VK][testing] Add scripts to facilitate operator testiing (#13593)

818d095

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* __->__ #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800081](https://our.internmc.facebook.com/intern/diff/D80800081)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>


          [ET-VK][ez] Consolidate tensor metadata calculation + buffer binding …

56ec8c8

…code

Pull Request resolved: #13594

As title, this diff consolidates logic used to calculate flipped and unsqueezed tensor metadata as well as initializing + retrieving buffer bindings for UBOs that contain tensor metadata.


@imported-using-ghimport

Differential Revision: [D80800085](https://our.internmc.facebook.com/intern/diff/D80800085/)
ghstack-source-id: 305143835

SS-JIA changed the base branch from gh/SS-JIA/296/base to main

August 23, 2025 14:04

SS-JIA requested review from larryliu0820 and kirklandsign as code owners

August 23, 2025 14:04

SS-JIA force-pushed the gh/SS-JIA/296/head branch from 1a001a3 to 56ec8c8 Compare

August 23, 2025 14:04

SS-JIA merged commit 4d095f9 into main

100 of 101 checks passed

SS-JIA deleted the gh/SS-JIA/296/head branch

August 23, 2025 14:05

SS-JIA added a commit that referenced this pull request


          [ET-VK] Introduce BufferMetadata GLSL struct to abstract tensor lay…

916c207

…out (#13595)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* __->__ #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800082](https://our.internmc.facebook.com/intern/diff/D80800082)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

SS-JIA added a commit that referenced this pull request


          [ET-VK][ez] Allow high dimensional tensors (for buffer storage) (#13596)

24d8fb4

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* __->__ #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800083](https://our.internmc.facebook.com/intern/diff/D80800083)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

SS-JIA added a commit that referenced this pull request


          [ET-VK] High dim tensor support for view, unsqueeze, squeeze, clone (#…

ed8cbc0

…13597)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ #13597
* #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800084](https://our.internmc.facebook.com/intern/diff/D80800084)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][ez] Fix partitioner logic of finding keepdim arg of reduce ops (

0d4fd84

pytorch#13598)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* pytorch#13595
* pytorch#13594
* pytorch#13593
* pytorch#13600
* pytorch#13599
* __->__ pytorch#13598

Title says it all. For reduce ops, their signature are not all alike so
some extra legwork needs to be done to identify specific arguments that
need to be checked.

Also included a small update to partitioner logging to improve
debuggability.

Differential Revision:
[D80741737](https://our.internmc.facebook.com/intern/diff/D80741737/)

---------

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][ez] Support grouped convolutions (pytorch#13599)

bb0ec6e

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* pytorch#13595
* pytorch#13594
* pytorch#13593
* pytorch#13600
* __->__ pytorch#13599
* pytorch#13598

Title says it all!

Differential Revision:
[D80741734](https://our.internmc.facebook.com/intern/diff/D80741734/)

---------

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][ez] Use XNNPACK's FuseBatchNorm pass (pytorch#13600)

e98da6d

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* pytorch#13595
* pytorch#13594
* pytorch#13593
* __->__ pytorch#13600
* pytorch#13599
* pytorch#13598

As title. Use XNNPACK's FuseBatchNorm pass since it can fuse into linear
layers as well.

Differential Revision:
[D80741735](https://our.internmc.facebook.com/intern/diff/D80741735/)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][testing] Add scripts to facilitate operator testiing (pytorch…

67b48c3

…#13593)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* pytorch#13595
* pytorch#13594
* __->__ pytorch#13593
* pytorch#13600
* pytorch#13599
* pytorch#13598

Differential Revision:
[D80800081](https://our.internmc.facebook.com/intern/diff/D80800081)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][ez] Consolidate tensor metadata calculation + buffer binding …

fb99e23

…code (pytorch#13594)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* pytorch#13595
* __->__ pytorch#13594
* pytorch#13593
* pytorch#13600
* pytorch#13599
* pytorch#13598

Differential Revision:
[D80800085](https://our.internmc.facebook.com/intern/diff/D80800085)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK] Introduce BufferMetadata GLSL struct to abstract tensor lay…

3a8edfd

…out (pytorch#13595)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* pytorch#13596
* __->__ pytorch#13595
* pytorch#13594
* pytorch#13593
* pytorch#13600
* pytorch#13599
* pytorch#13598

Differential Revision:
[D80800082](https://our.internmc.facebook.com/intern/diff/D80800082)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK][ez] Allow high dimensional tensors (for buffer storage) (pyto…

1653dbf

…rch#13596)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* pytorch#13597
* __->__ pytorch#13596
* pytorch#13595
* pytorch#13594
* pytorch#13593
* pytorch#13600
* pytorch#13599
* pytorch#13598

Differential Revision:
[D80800083](https://our.internmc.facebook.com/intern/diff/D80800083)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          [ET-VK] High dim tensor support for view, unsqueeze, squeeze, clone (p…

4f7871a

…ytorch#13597)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ pytorch#13597
* pytorch#13596
* pytorch#13595
* pytorch#13594
* pytorch#13593
* pytorch#13600
* pytorch#13599
* pytorch#13598

Differential Revision:
[D80800084](https://our.internmc.facebook.com/intern/diff/D80800084)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported