Skip to content

[ET-VK][ez] Support grouped convolutions #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2025
Merged

[ET-VK][ez] Support grouped convolutions #13599

merged 6 commits into from
Aug 23, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 22, 2025 •
edited
Loading

ssjia added 2 commits August 22, 2025 07:30
[ET-VK][ez] Fix partitioner logic of finding keepdim arg of reduce ops
f532f65 
Title says it all. For reduce ops, their signature are not all alike so some extra legwork needs to be done to identify specific arguments that need to be checked.

Also included a small update to partitioner logging to improve debuggability.

Differential Revision: [D80741737](https://our.internmc.facebook.com/intern/diff/D80741737/)

[ghstack-poisoned]
[ET-VK][ez] Support grouped convolutions
173946d 
Title says it all!

Differential Revision: [D80741734](https://our.internmc.facebook.com/intern/diff/D80741734/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13599

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 1016403 with merge base f90a836 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80741734

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Aug 22, 2025
Merged
Merged
Merged
ssjia added 2 commits August 22, 2025 14:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80741734

ssjia added 2 commits August 22, 2025 21:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80741734

SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK][ez] Fix partitioner logic of finding keepdim arg of reduce ops (
6c1f9fa 
#13598)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* __->__ #13598

Title says it all. For reduce ops, their signature are not all alike so
some extra legwork needs to be done to identify specific arguments that
need to be checked.

Also included a small update to partitioner logging to improve
debuggability.

Differential Revision:
[D80741737](https://our.internmc.facebook.com/intern/diff/D80741737/)

---------

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
@SS-JIA SS-JIA changed the base branch from gh/SS-JIA/301/base to main August 23, 2025 13:49
@SS-JIA SS-JIA merged commit 975a4a3 into main Aug 23, 2025
103 of 106 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/301/head branch August 23, 2025 13:49
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK][ez] Use XNNPACK's FuseBatchNorm pass (#13600)
bd70337 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* #13593
* __->__ #13600
* #13599
* #13598

As title. Use XNNPACK's FuseBatchNorm pass since it can fuse into linear
layers as well.

Differential Revision:
[D80741735](https://our.internmc.facebook.com/intern/diff/D80741735/)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK][testing] Add scripts to facilitate operator testiing (#13593)
818d095 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* #13594
* __->__ #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800081](https://our.internmc.facebook.com/intern/diff/D80800081)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK][ez] Consolidate tensor metadata calculation + buffer binding …
4d095f9 
…code (#13594)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* #13595
* __->__ #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800085](https://our.internmc.facebook.com/intern/diff/D80800085)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK] Introduce BufferMetadata GLSL struct to abstract tensor lay…
916c207 
…out (#13595)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* #13596
* __->__ #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800082](https://our.internmc.facebook.com/intern/diff/D80800082)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK][ez] Allow high dimensional tensors (for buffer storage) (#13596)
24d8fb4 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #13597
* __->__ #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800083](https://our.internmc.facebook.com/intern/diff/D80800083)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
SS-JIA added a commit that referenced this pull request Aug 23, 2025
@SS-JIA
[ET-VK] High dim tensor support for view, unsqueeze, squeeze, clone (#…
ed8cbc0 
…13597)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* __->__ #13597
* #13596
* #13595
* #13594
* #13593
* #13600
* #13599
* #13598

Differential Revision:
[D80800084](https://our.internmc.facebook.com/intern/diff/D80800084)

Co-authored-by: ssjia <ssjia@devvm5117.ash0.facebook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SS-JIA @facebook-github-bot @manuelcandales