test: Update examples and test runner with improved error handling #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update hap_example with proper handling for skip and failed cases - Add multithreading example computing parallel sum - Update fastrpc_test runner to handle pass, failed, and skipped cases - Improve test result reporting and categorization Signed-off-by: Vinayak Katoch <vkatoch@qti.qualcomm.com>
ekanshibu
approved these changes
Dec 10, 2025
Chennak-quic
approved these changes
Dec 10, 2025
basak-qcom
reviewed
Dec 11, 2025
|
|
||
| if (tests_failed > 0) { | ||
| printf("\nRESULT: %d test(s) FAILED\n", tests_failed); | ||
| return tests_failed; |
There was a problem hiding this comment.
There's an overflow issue here. For example if there are 256 tests, then the lower 8 bits will be 0 and therefore indistinguishable from success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #231