-
Notifications
You must be signed in to change notification settings - Fork 18
Specification for removing bicep-types submodule and migrating to pnpm + Go modules #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brooke-hamilton
wants to merge
8
commits into
radius-project:main
Choose a base branch
from
brooke-hamilton:001-remove-bicep-types-submodule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Specification for removing bicep-types submodule and migrating to pnpm + Go modules #138
brooke-hamilton
wants to merge
8
commits into
radius-project:main
from
brooke-hamilton:001-remove-bicep-types-submodule
+1,948
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
brooke-hamilton
added a commit
to radius-project/radius
that referenced
this pull request
Jan 24, 2026
# Description This PR updates Go code to use the `bicep-types-go` package as a standard Go module dependency fetched via `go get github.com/Azure/bicep-types/src/bicep-types-go@<commit hash>`, rather than relying on the git submodule. The submodule remains for TypeScript/pnpm tooling, but Go tooling now references the package directly from the `Azure/bicep-types` repository. This PR is step 1 of 2 in a two-step update to remove the git submodule. The plan is here: radius-project/design-notes#138 **Changes:** - Removed the `replace` directive in `go.mod` that pointed to the local submodule - Added direct dependency on `github.com/Azure/bicep-types/src/bicep-types-go` - Updated contributor documentation to clarify when the submodule is required ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Related issue #10913 - Design document: radius-project/design-notes#138 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [x] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [x] Yes <!-- TaskRadio design-pr --> - [ ] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [x] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [x] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [x] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [x] Not applicable <!-- TaskRadio recipes-pr --> --------- Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a feature specification for migrating the Radius repository from a git submodule for bicep-types to direct dependency references using Go modules and pnpm.
Changes
spec.md): Complete feature specification with user stories, requirements, and success criteriaMotivation
The current bicep-types git submodule causes:
Related Issue
radius-project/radius#10913