[BUG] Fix Vamana Serialization#1966
Merged
rapids-bot[bot] merged 5 commits intorapidsai:release/26.04from Apr 1, 2026
Merged
Conversation
Contributor
tarang-jain
commented
Mar 30, 2026
tarang-jain
commented
- Add sync_stream for D2H copies of the graph
- strided copy to copy the strided dataset
Contributor
Author
tarang-jain
added
non-breaking
bkarsin
approved these changes
Mar 30, 2026
Contributor
bkarsin
left a comment
bkarsin
left a comment
There was a problem hiding this comment.
Should get a wrapper put around the memcpy, but that should be a separate, future PR.
tarang-jain
changed the title
jinsolp
approved these changes
Mar 31, 2026
Contributor
jinsolp
left a comment
jinsolp
left a comment
There was a problem hiding this comment.
I believe you would have tested the correctness of this code from your end (I understand the serialized graph needs to be fed into diskann), but is there a way to check this correctness in cuVS? For a case where stride != dim? Approving in the meantime.
Contributor
Author
|
/merge |
cjnolet
requested changes
Apr 1, 2026
Member
|
Please see my comment above about the wrapper for cuda memcpy2d. Don't merge PRs when I've asked for a prereq, please. |
cjnolet
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.