Skip to content

[BUG] Fix Vamana Serialization #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Apr 1, 2026
+15 −7
Merged

[BUG] Fix Vamana Serialization #1966

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
755d8ad
fix vamana serialization bug
tarang-jain Mar 30, 2026
f340d3a
Merge branch 'release/26.04' into vamana-serialize
tarang-jain Mar 30, 2026
3806ab3
raft::copy_matrix
tarang-jain Apr 1, 2026
a5e125c
Merge branch 'vamana-serialize' of https://github.com/tarang-jain/cuv…
tarang-jain Apr 1, 2026
2fe0fc0
Merge branch 'release/26.04' into vamana-serialize
tarang-jain Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions cpp/src/neighbors/detail/vamana/vamana_serialize.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <raft/core/nvtx.hpp>
#include <raft/core/resource/cuda_stream.hpp>
#include <raft/core/serialize.hpp>
#include <raft/util/cudart_utils.hpp>

#include "../dataset_serialize.hpp"

Expand Down Expand Up @@ -65,13 +66,19 @@ void serialize_dataset(raft::resources const& res,
const auto* strided_dataset =
dynamic_cast<const cuvs::neighbors::strided_dataset<T, int64_t>*>(dataset);
if (strided_dataset) {
auto h_dataset =
raft::make_host_matrix<T, int64_t>(strided_dataset->n_rows(), strided_dataset->dim());
raft::copy(res,
raft::make_host_vector_view(h_dataset.data_handle(),
strided_dataset->n_rows() * strided_dataset->dim()),
raft::make_device_vector_view(strided_dataset->view().data_handle(),
strided_dataset->n_rows() * strided_dataset->dim()));
auto nrows = strided_dataset->n_rows();
auto dim = strided_dataset->dim();
auto stride = strided_dataset->stride();
auto d_data = strided_dataset->view();
auto h_dataset = raft::make_host_matrix<T, int64_t>(nrows, dim);
raft::copy_matrix(h_dataset.data_handle(),
dim,
d_data.data_handle(),
stride,
dim,
nrows,
raft::resource::get_cuda_stream(res));
raft::resource::sync_stream(res);
to_file(dataset_base_file, h_dataset);
} else {
RAFT_LOG_DEBUG("dynamic_cast to strided_dataset failed");
Expand All @@ -91,6 +98,7 @@ void serialize_dataset(raft::resources const& res,
try {
auto h_dataset = raft::make_host_matrix<T, int64_t>(dataset.extent(0), dataset.extent(1));
raft::copy(res, h_dataset.view(), dataset);
raft::resource::sync_stream(res);
to_file(dataset_base_file, h_dataset);
} catch (std::bad_alloc& e) {
RAFT_LOG_INFO("Failed to serialize dataset");
Expand Down
Loading