Update #169: Created RedRat remote type #172
Conversation
TB-1993
force-pushed
the
feature/gh169_create_redrat_RC_interface
branch
from
a306a4c to
67144bd
Compare
Created RedRat remoteController. Created remoteController interface class. Updated example rack config to show redrat parameters. Created example redrat keymap.
TB-1993
force-pushed
the
feature/gh169_create_redrat_RC_interface
branch
from
67144bd to
76d31fe
Compare
kanjoe24
left a comment
kanjoe24
left a comment
There was a problem hiding this comment.
Does this need any update in requirements.txt? Just double confirming .
| from framework.core.remoteControllerModules.arduino import remoteArduino | ||
| from framework.core.remoteControllerModules.none import remoteNone | ||
| from framework.core.remoteControllerModules.keySimulator import remoteKeySimulator | ||
| from framework.core.remoteControllerModules import remoteArduino, \ |
There was a problem hiding this comment.
Do we need to import every thing even though we don't use all of them at a time? Can we consider this based on the rack config file and see for the only devices those are present in that?
There was a problem hiding this comment.
Yes, unfortunately we do. This is how we allow for all these different types in the rack configs. We don't actually instantiate any objects from these classes until we've read the config. So it's still pretty minimal memory usage.
| if self._is_open: | ||
| self._socket.close() | ||
| self._is_open = False | ||
|
|
There was a problem hiding this comment.
Can we have some description and parametric information for these definitions as well?
srinivasgtl
left a comment
srinivasgtl
left a comment
There was a problem hiding this comment.
how is example_keymap and example_redrat_keymap.yml used? Are they both used?
| self._netbox_ip = config.get('netbox_ip') | ||
| self._output = config.get('output', 1) | ||
|
|
||
| def sendKey(self, code, repeat, delay): |
There was a problem hiding this comment.
Same here, can we have some descriptions of this definition with parameter info.
Let me write up a doc for using the remote controller. It's silly that we don't have one, and it would explain this. |
TB-1993
force-pushed
the
feature/gh169_create_redrat_RC_interface
branch
from
b426385 to
38f6fc4
Compare
TB-1993
force-pushed
the
feature/gh169_create_redrat_RC_interface
branch
from
38f6fc4 to
bbccbfb
Compare
- Added a check to ensure the IR Netbox is available on the hub connected to (This also confirms it is a Hub that is connected to). - Added docstrings to the methods in the Hub class to better explain them.
Created RedRat remoteController. Created remoteController interface class. Updated example rack config to show redrat parameters. Created example redrat keymap.
Closes #169