[#117] Fix min-h-screen double-nesting causing 44px overflow#121
[#117] Fix min-h-screen double-nesting causing 44px overflow#121realproject7 merged 2 commits intomainfrom
Conversation
Replace min-h-screen on page wrapper divs with min-h-[calc(100vh-2.75rem)] to account for the nav's pt-11 (44px) offset in root layout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the double min-h-screen nesting exactly where issue #117 identified it, using min-h-[calc(100vh-2.75rem)] to preserve vertical centering without the 44px overflow. The change is narrow, consistent across the affected pages, and CI passed.
Findings
- None.
Decision
Approve because the implementation matches the acceptance criteria, stays focused on the overflow bug, and the lint-and-typecheck check passed.
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: REQUEST CHANGES
The fix is correct and consistent across the 5 listed files — calc(100vh - 2.75rem) properly accounts for the pt-11 navbar padding.
Required fix: src/app/story/[storylineId]/page.tsx has a NotFound component with the same min-h-screen double-nesting bug. Should be fixed in this PR for completeness.
Optional: The 2.75rem magic number is now in 8+ places. Consider a follow-up to extract it into a CSS custom property or Tailwind theme variable.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b Re-review: APPROVE
All 8 min-h-screen instances now fixed across 6 files, including the NotFound component in story/[storylineId]/page.tsx. Consistent calc(100vh - 2.75rem) replacement, flex centering preserved throughout.
Fixes #117
Summary
min-h-screen+pt-11(44px nav offset) to the children wrappermin-h-screenon their own wrapper divs, causing a 44px scroll overflowmin-h-screenwithmin-h-[calc(100vh-2.75rem)]on each affected page wrapper to account for the nav heightFiles changed
src/app/create/page.tsx— 2 wrapper divs (not-connected + published states)src/app/chain/page.tsx— 2 wrapper divs (not-connected + published states)src/app/dashboard/reader/page.tsx— 1 wrapper div (not-connected state)src/app/dashboard/writer/page.tsx— 1 wrapper div (not-connected state)src/app/discover/page.tsx— 1 wrapper div (database-unavailable state)Test plan
🤖 Generated with Claude Code