Skip to content

[#117] Fix min-h-screen double-nesting causing 44px overflow#121

Merged
realproject7 merged 2 commits intomainfrom
task/117-fix-min-h-screen-overflow
Mar 15, 2026
Merged

[#117] Fix min-h-screen double-nesting causing 44px overflow#121
realproject7 merged 2 commits intomainfrom
task/117-fix-min-h-screen-overflow

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Fixes #117

Summary

  • Root layout applies min-h-screen + pt-11 (44px nav offset) to the children wrapper
  • Five pages also used min-h-screen on their own wrapper divs, causing a 44px scroll overflow
  • Replaced min-h-screen with min-h-[calc(100vh-2.75rem)] on each affected page wrapper to account for the nav height

Files changed

  • src/app/create/page.tsx — 2 wrapper divs (not-connected + published states)
  • src/app/chain/page.tsx — 2 wrapper divs (not-connected + published states)
  • src/app/dashboard/reader/page.tsx — 1 wrapper div (not-connected state)
  • src/app/dashboard/writer/page.tsx — 1 wrapper div (not-connected state)
  • src/app/discover/page.tsx — 1 wrapper div (database-unavailable state)

Test plan

  • Verify no vertical scrollbar on each affected page when content fits viewport
  • Verify empty/error states remain vertically centered
  • Verify normal content pages (with form content) still scroll naturally when content exceeds viewport

🤖 Generated with Claude Code

Replace min-h-screen on page wrapper divs with min-h-[calc(100vh-2.75rem)]
to account for the nav's pt-11 (44px) offset in root layout.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR fixes the double min-h-screen nesting exactly where issue #117 identified it, using min-h-[calc(100vh-2.75rem)] to preserve vertical centering without the 44px overflow. The change is narrow, consistent across the affected pages, and CI passed.

Findings

  • None.

Decision

Approve because the implementation matches the acceptance criteria, stays focused on the overflow bug, and the lint-and-typecheck check passed.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Review: REQUEST CHANGES

The fix is correct and consistent across the 5 listed files — calc(100vh - 2.75rem) properly accounts for the pt-11 navbar padding.

Required fix: src/app/story/[storylineId]/page.tsx has a NotFound component with the same min-h-screen double-nesting bug. Should be fixed in this PR for completeness.

Optional: The 2.75rem magic number is now in 8+ places. Consider a follow-up to extract it into a CSS custom property or Tailwind theme variable.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b Re-review: APPROVE

All 8 min-h-screen instances now fixed across 6 files, including the NotFound component in story/[storylineId]/page.tsx. Consistent calc(100vh - 2.75rem) replacement, flex centering preserved throughout.

@realproject7 realproject7 merged commit d59f1f3 into main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] min-h-screen double-nesting causes 44px scroll overflow

2 participants