Skip to content

[#117] Fix min-h-screen double-nesting causing 44px overflow #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 2 commits into from
Mar 15, 2026
Merged

[#117] Fix min-h-screen double-nesting causing 44px overflow #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5078b
[#117] Fix min-h-screen double-nesting causing 44px overflow
realproject7 Mar 15, 2026
1f2277d
[#117] Also fix min-h-screen in story/[storylineId] NotFound
realproject7 Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/chain/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function ChainPlotPage() {

if (!isConnected) {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-4 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-4 px-6">
<p className="text-muted text-sm">
Connect your wallet to chain a plot.
</p>
Expand All @@ -66,7 +66,7 @@ export default function ChainPlotPage() {

if (state === "published") {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-6 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-6 px-6">
<h1 className="text-accent text-2xl font-bold">Plot chained!</h1>
<div className="flex gap-3">
{storylineId && (
Expand Down
4 changes: 2 additions & 2 deletions src/app/create/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function CreateStorylinePage() {

if (!isConnected) {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-4 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-4 px-6">
<p className="text-muted text-sm">
Connect your wallet to create a storyline.
</p>
Expand All @@ -48,7 +48,7 @@ export default function CreateStorylinePage() {

if (state === "published") {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-6 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-6 px-6">
<h1 className="text-accent text-2xl font-bold">Storyline created!</h1>
<div className="flex gap-3">
<Link
Expand Down
2 changes: 1 addition & 1 deletion src/app/dashboard/reader/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default function ReaderDashboard() {

if (!isConnected) {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-4 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-4 px-6">
<p className="text-muted text-sm">
Connect your wallet to view your dashboard.
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/app/dashboard/writer/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function WriterDashboard() {

if (!isConnected) {
return (
<div className="flex min-h-screen flex-col items-center justify-center gap-4 px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center gap-4 px-6">
<p className="text-muted text-sm">
Connect your wallet to view your dashboard.
</p>
Expand Down
2 changes: 1 addition & 1 deletion src/app/discover/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default async function DiscoverPage({
const supabase = createServerClient();
if (!supabase) {
return (
<div className="flex min-h-screen items-center justify-center">
<div className="flex min-h-[calc(100vh-2.75rem)] items-center justify-center">
<p className="text-muted text-sm">Database unavailable</p>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion src/app/story/[storylineId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ function PlotEntry({ plot }: { plot: Plot }) {

function NotFound({ message }: { message: string }) {
return (
<div className="flex min-h-screen flex-col items-center justify-center px-6">
<div className="flex min-h-[calc(100vh-2.75rem)] flex-col items-center justify-center px-6">
<p className="text-muted text-sm">{message}</p>
</div>
);
Expand Down
Loading